Fix readPixels (pass the gl-enums-test.html test)

RESOLVED FIXED

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bjacob, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We had some weird code in there, making us fail that test.
(Reporter)

Comment 1

7 years ago
Created attachment 493454 [details] [diff] [review]
fix readpixels
Attachment #493454 - Flags: review?(vladimir)
Comment on attachment 493454 [details] [diff] [review]
fix readpixels

erm wait, I just added that code in bug 612336  (was checked in with wrong bug #).  We have to synthesize INVALID_OPERATION if both format and type are invalid; the test even says:

  // note that the GL error is INVALID_OPERATION if both format and type are invalid, but INVALID_ENUM if only one is.

Need to update our copy of the test suite with latest from svn again looks like.
(Reporter)

Comment 3

7 years ago
ok, closing.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
(Reporter)

Comment 4

7 years ago
We're still failing this test (from svn). Also, it doesn't seem to have anymore the comment that you were referring to:

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/gl-enum-tests.html

Moreover I can't see where in the WebGL or GL ES spec it would prescribe this behavior. It seems to me that at some point in the past this test was wrong, and has been fixed since.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Reporter)

Updated

6 years ago
Attachment #493454 - Flags: review?(vladimir)
(Reporter)

Comment 5

6 years ago
This test is now passing on all platform on the build slaves.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.