Closed Bug 615015 Opened 14 years ago Closed 14 years ago

"ASSERTION: bad action nesting!"

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: jruderman, Assigned: ehsan.akhgari)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase (requires focus)
295 bytes, text/html
Details
stack traces
22.68 KB, text/plain
Details
Patch (v1)
3.89 KB, patch
roc
: review+
roc
: approval2.0+
Details | Diff | Splinter Review 
Might be related to bug 336091 and bug 496337.

###!!! ASSERTION: transaction did not execute properly: '(NS_SUCCEEDED(result))', file editor/libeditor/base/nsEditor.cpp, line 674

###!!! ASSERTION: bad action nesting!: 'mActionNesting>0', file editor/libeditor/html/nsHTMLEditRules.cpp, line 397

###!!! ASSERTION: bad state: 'mUpdateCount > 0', file editor/libeditor/base/nsEditor.cpp, line 4184

###!!! ASSERTION: Someone forgot to call EndUpdateViewBatch!: '!mRootVM', file nsIViewManager.h, line 297
Attached file stack traces — 

    
    

    
  
It also makes the entire browser window stop drawing (and makes it black in my case).
Depends on: 611798

    
    

    
  
If UpdateView batches get unbalanced that would mess up the drawing.

    
    

    
  
This is partly solved by my patch in bug 615450.  With that patch, this is the assertion that I get:

###!!! ASSERTION: transaction did not execute properly: '(NS_SUCCEEDED(result))', file /Users/ehsanakhgari/moz/mozilla-central/editor/libeditor/base/nsEditor.cpp, line 674

    
  
Depends on: 615450
No longer depends on: 611798

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch (v1)
        — 
          — Splinter Review
      

    


  
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #494305 -
        Flags: review?(roc)

    
  

        Attachment #494305 -
        Flags: approval2.0?

    
  
Whiteboard: [needs landing]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/af358fe76628

Also pushed a followup to fix an assertion count check:

http://hg.mozilla.org/mozilla-central/rev/a84d8af1af12
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: