615189 - clean up FireAccessibleFocusEvent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Marco Zehe (:MarcoZ)]

Comment on attachment 493663 [details] [diff] [review]
patch

r=me for the tests, thanks!

Comment 2

[Fernando Herrera]

test_menu.xul is giving a timeout on linux. That is probably because VK_ALT is not focusing the menu bar.

we could use:

synthesizeKey("F", { altKey: true });

but that would open the file popup and focus the newtab node.

Comment 3

[Fernando Herrera]

ok, alt is not focusing the menu bar because of the default linux preferences. It's going to be tricky to test this under linux, because even if we add this to the test:

      var prefs = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefBranch);
      prefs.setBoolPref("ui.key.menuAccessKeyFocuses", true);

that pref is loaded only at init time at nsMenuBarListener::InitAccessKey that happens before the js code gets executed.

Hardcoding the preference to test this, I'm getting:
Event queue:
  invoke: activate menubar

Event type: menu start. Target: [ 'menubar@id='menubar' node' , role: menubar, name: 'Application', address: 0xa5144ec0]. Listeners count: 1

*****
EQ matched: menu start
*****

Event type: focus. Target: [ 'menu@id='menufile' node' , role: parent menuitem, name: 'File', address: 0xa515ace0]. Listeners count: 1

*****
EQ matched: focus
*****
Event queue:
  invoke: move to next menu

Event type: focus. Target: [ 'menu@id='menuedit' node' , role: parent menuitem, name: 'Edit', address: 0xa6c7f470]. Listeners count: 1

*****
EQ matched: focus
*****
Event queue:
  invoke: open menu

Event type: focus. Target: [ 'menuitem@id='menuitemundo' node' , role: menuitem, name: 'Undo', address: 0xa51e6740]. Listeners count: 1

Instead of the expected menupopup start for menupopupedit


Anyway, I have been testing windows build and the alt for menu activation is behaving in a different way.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 5

[alexander :surkov (:asurkov)]

try server build - http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-10fb57788c90

Comment 6

[Fernando Herrera]

Hum, I saw the try server tests still failing under linux. Tried with debug options, and those are the events I'm seeing:


Event queue:
  invoke: open file menu by alt+F press

Event type: menu start. Target: [ 'menubar@id='menubar' node' , role: menubar, name: 'Application', address: 0xa5750e70]. Listeners count: 1

Event type: focus. Target: [ 'menuitem@id='menuitem-newtab' node' , role: menuitem, name: 'New Tab', address: 0xa6ed1240]. Listeners count: 1


Event queue:
  invoke: open edit menu by lef arrow press

Event type: focus. Target: [ 'menu@id='menuitem-edit' node' , role: parent menuitem, name: 'Edit', address: 0xa5beda60]. Listeners count: 1

Event type: focus. Target: [ 'menuitem@id='menuitem-undo' node' , role: menuitem, name: 'Undo', address: 0xafc917e0]. Listeners count: 1

Event queue:
  invoke: close edit menu, leave menubar

Event type: focus. Target: [ 'document node' , role: application, name: 'Accessible menu events testing for XUL menu', address: 0xa570ea5c]



Event type: menu end. Target: [ 'menubar@id='menubar' node' , role: menubar, name: 'Application', address: 0xa5750e70]. Listeners count: 1

So it looks like we are missing EVENT_MENUPOPUP_START/END events.

Comment 7

[Marco Zehe (:MarcoZ)]

Feedback on this try-server build:
1. Menus work with both JAWS and NVDA as expected.
2. The Youtube problem I describe with JAWS on bug 615520 is NOT present in this try server build.

This build is good from my end!

Comment 8

[Marco Zehe (:MarcoZ)]

Umm, that was supposed to read bug 615220 comment#5.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #8)
> Umm, that was supposed to read bug 615220 comment#5.

Marco, what about latest try server build in bug bug 615220?

Comment 10

[alexander :surkov (:asurkov)]

Attachment: tests: patch1

Comment 11

[alexander :surkov (:asurkov)]

Attachment: cleanup: patch1

Comment 12

[Fernando Herrera]

Comment on attachment 494668 [details] [diff] [review]
tests: patch1

tests looks good, even if not passing under linux :)
r=me

Comment 13

[alexander :surkov (:asurkov)]

part1 is landed on 2.0 http://hg.mozilla.org/mozilla-central/rev/eb4d2a3dc388

Comment 14

[Fernando Herrera]

Comment on attachment 494669 [details] [diff] [review]
cleanup: patch1

r=me for the cleanup too

Comment 15

[alexander :surkov (:asurkov)]

landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/711d073c2338

Comment 16

[David Bolter [:davidb] (NeedInfo me for attention)]

Note test_menu fails for me on mac.