Closed Bug 615213 Opened 10 years ago Closed 8 years ago

Remove nsIGlobalHistory (Components.classes["@mozilla.org/browser/global-history;1"]) code

Categories

(Core :: DOM: Navigation, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
blocking2.0 --- -

People

(Reporter: sgautherie, Assigned: marco)

References

()

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/docshell/base/Makefile.in
still has
{
55 SDK_XPIDLSRCS = \
56                 nsIGlobalHistory.idl \
57                 $(NULL)
}

But nsGlobalHistoryAdapter.cpp was removed by bug 568691.
http://hg.mozilla.org/mozilla-central/rev/08410c390aa9

Then it seems this interface is not registered (anywhere) anymore.

1) Was it intended or just missed?
2) Are there other interfaces in the same case?
blocking2.0: --- → ?
Fwiw,
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsIGlobalHistory.idl
42  * @status DEPRECATED. This interface is still accepted, but new
43  *         implementations should use nsIGlobalHistory2.

Then you might want to take Gecko 2.0 as an opportunity to remove this interface completely.
But that's just a reminder, not a request.
This was an intentional change. We should remove the interface.
blocking2.0: ? → -
Component: XPCOM → Document Navigation
QA Contact: xpcom → docshell
No longer blocks: 603031
Blocks: 615219
"blocking2.0=?":
Stop exposing/building an interface that is actually unavailable now.
No longer blocks: data-driven-compreg
blocking2.0: - → ?
Flags: in-testsuite-
Keywords: regression
Summary: Components.classes["@mozilla.org/browser/global-history;1"] isn't registered anymore → Remove nsIGlobalHistory (Components.classes["@mozilla.org/browser/global-history;1"]) code
No, I don't want to remove it now because extension code which doesn't actually use it may still be trying to use Components.classes.nsIGlobalHistory.
blocking2.0: ? → -
(In reply to comment #2)
> We should remove the interface.

(In reply to comment #4)
> I don't want to remove [the code]

Wow, I'm puzzled!
So you say you want to "keep (building) the code in the tree, yet not register the interface anymore"?

(I wonder what good that does.
Maybe take bug 603031 + bug 615219 as an example.)
No, I'm saying we should remove the interface *after* we branch for Firefox 4. The *interface* is still present in Firefox 4, but there are no implementations of it, so it's vestigial.
(In reply to comment #6)

Hum (I'm not sure I fully understand, but), in other words, am I right to say that:
*this bug is Future for now (until FFv4 branches)?
*ChatZilla is now required to use nsIGlobalHistory2 (bug 615219) to keep working with Gecko 2.0b2+?
Target Milestone: --- → Future
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> No, I'm saying we should remove the interface *after* we branch for Firefox
> 4.

So, we are quite far from Firefox 4, we still don't have an implementation of this interface, so whoever tries to use it is likely just not doing what he thinks.

Benjamin, would you be fine to actually do the removal now?  We can reach tracked add-ons authors through the AMO team, though at this point I expect those being just onowned and unmaintained add-ons.
Yes, please remove.
Attached patch PatchSplinter Review
Remove nsIGlobalHistory (if we want to)
Attachment #620783 - Flags: review?(benjamin)
Keywords: addon-compat
Attachment #620783 - Flags: review?(benjamin) → review+
I assume benjamin's review here is also valid as a SR for the interface change, and after all this was already in the plan from a long time.  So this can land.
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Keywords: checkin-needed
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/c0110c112580
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.