The default bug view has changed. See this FAQ.

Remove nsIGlobalHistory (Components.classes["@mozilla.org/browser/global-history;1"]) code

RESOLVED FIXED in mozilla15

Status

()

Core
Document Navigation
--
major
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: marco)

Tracking

(Blocks: 1 bug, {addon-compat, dev-doc-complete})

Trunk
mozilla15
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking2.0 -)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
http://mxr.mozilla.org/mozilla-central/source/docshell/base/Makefile.in
still has
{
55 SDK_XPIDLSRCS = \
56                 nsIGlobalHistory.idl \
57                 $(NULL)
}

But nsGlobalHistoryAdapter.cpp was removed by bug 568691.
http://hg.mozilla.org/mozilla-central/rev/08410c390aa9

Then it seems this interface is not registered (anywhere) anymore.

1) Was it intended or just missed?
2) Are there other interfaces in the same case?
(Reporter)

Updated

6 years ago
blocking2.0: --- → ?
(Reporter)

Comment 1

6 years ago
Fwiw,
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsIGlobalHistory.idl
42  * @status DEPRECATED. This interface is still accepted, but new
43  *         implementations should use nsIGlobalHistory2.

Then you might want to take Gecko 2.0 as an opportunity to remove this interface completely.
But that's just a reminder, not a request.
This was an intentional change. We should remove the interface.
blocking2.0: ? → -
Component: XPCOM → Document Navigation
QA Contact: xpcom → docshell
(Reporter)

Updated

6 years ago
No longer blocks: 603031
(Reporter)

Updated

6 years ago
Blocks: 615219
(Reporter)

Comment 3

6 years ago
"blocking2.0=?":
Stop exposing/building an interface that is actually unavailable now.
No longer blocks: 568691
blocking2.0: - → ?
Depends on: 568691
Flags: in-testsuite-
Keywords: regression
Summary: Components.classes["@mozilla.org/browser/global-history;1"] isn't registered anymore → Remove nsIGlobalHistory (Components.classes["@mozilla.org/browser/global-history;1"]) code
No, I don't want to remove it now because extension code which doesn't actually use it may still be trying to use Components.classes.nsIGlobalHistory.
blocking2.0: ? → -
(Reporter)

Comment 5

6 years ago
(In reply to comment #2)
> We should remove the interface.

(In reply to comment #4)
> I don't want to remove [the code]

Wow, I'm puzzled!
So you say you want to "keep (building) the code in the tree, yet not register the interface anymore"?

(I wonder what good that does.
Maybe take bug 603031 + bug 615219 as an example.)
No, I'm saying we should remove the interface *after* we branch for Firefox 4. The *interface* is still present in Firefox 4, but there are no implementations of it, so it's vestigial.
(Reporter)

Comment 7

6 years ago
(In reply to comment #6)

Hum (I'm not sure I fully understand, but), in other words, am I right to say that:
*this bug is Future for now (until FFv4 branches)?
*ChatZilla is now required to use nsIGlobalHistory2 (bug 615219) to keep working with Gecko 2.0b2+?
Target Milestone: --- → Future

Updated

5 years ago
Blocks: 699850
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> No, I'm saying we should remove the interface *after* we branch for Firefox
> 4.

So, we are quite far from Firefox 4, we still don't have an implementation of this interface, so whoever tries to use it is likely just not doing what he thinks.

Benjamin, would you be fine to actually do the removal now?  We can reach tracked add-ons authors through the AMO team, though at this point I expect those being just onowned and unmaintained add-ons.
Yes, please remove.
Created attachment 620783 [details] [diff] [review]
Patch

Remove nsIGlobalHistory (if we want to)
(Reporter)

Updated

5 years ago
Attachment #620783 - Flags: review?(benjamin)

Updated

5 years ago
Keywords: addon-compat
Attachment #620783 - Flags: review?(benjamin) → review+
I assume benjamin's review here is also valid as a SR for the interface change, and after all this was already in the plan from a long time.  So this can land.

Updated

5 years ago
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
I've sent the patch to try: https://tbpl.mozilla.org/?tree=Try&rev=fce464dcb502
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0110c112580
Keywords: checkin-needed
Target Milestone: Future → mozilla15

Updated

5 years ago
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/c0110c112580
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Doc updated:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIGlobalHistory

Mentioned on Firefox 15 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.