Bug 699850 (asyncHistory)

[meta] Refactor all synchronous history APIs to use async Storage APIs

NEW
Unassigned

Status

()

Toolkit
Places
P5
normal
6 years ago
6 months ago

People

(Reporter: mak, Unassigned)

Tracking

(Depends on: 5 bugs, Blocks: 1 bug, {meta, perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy:p1] [tracking][qf:meta])

(Reporter)

Description

6 years ago
All of the history APIs used in browsing and Sync are already async, we should remove and replace all the remainig synchronous APIs. This may require some deep test rewriting, but we can do fake-sync wrappers for that.
Alias: asyncHistory
Assignee: nobody → dteller
I'll take it, but I'll need some help to get started.
(Reporter)

Comment 2

6 years ago
I think you choose the hardest one, this will have to be splitted in a lot of smaller bugs, but don't want to scare you :)
History changes (in form of visits addition or removal) in the browser UI are already using async APIs, but we have to convert all of nsIBrowserHistory and nsINavHistoryService (there also other interfaces, but those are mostly dependent on these and should be done later).

A first dependent bug may be to deprecate addVisit and addPageWithDetails, that are used in a LOT of tests, to avoid rewriting all the tests we can likely write an addVisit wrapper that uses updatePlaces async API and spin the events loop till we get the callback. We should push people toward updatePlaces API.
Related to this, we should rewrite the importExport service (bug 482911), hsivonen wanted to do that but he's likely really busy.

If we kill any possibility to add visits synchronously, we can likely start converting nsIBrowserHistory the other methods, like removals.

If you prefer starting from a smaller project, Favicons service has to be finished (is partially async) and has less connections to other services.
Bug 672681 is another interesting entry point.
(Reporter)

Comment 3

6 years ago
hm I said the importExport service, but I meant the migrators, whatever uses addPageWithDetails.
Depends on: 700250
De-assigning myself in case someone wants to take it. Otherwise, I will eventually return to it.
Assignee: dteller → nobody
(Reporter)

Updated

6 years ago
Blocks: 561450
(Reporter)

Updated

6 years ago
Depends on: 739217
(Reporter)

Updated

6 years ago
Depends on: 739218
(Reporter)

Updated

6 years ago
No longer blocks: 561450
(Reporter)

Updated

6 years ago
Depends on: 739219
(Reporter)

Comment 5

6 years ago
This is basically a tracking bug, so making it properly that.
Keywords: meta
Whiteboard: [snappy]

Updated

6 years ago
Whiteboard: [snappy] → [snappy:p1]
(Reporter)

Updated

6 years ago
Depends on: 615213
(Reporter)

Updated

6 years ago
No longer depends on: 739217

Updated

5 years ago
Depends on: 648232

Updated

5 years ago
Blocks: 648232
No longer depends on: 648232
(Reporter)

Updated

5 years ago
Depends on: 834457
(Reporter)

Updated

5 years ago
Depends on: 834539
(Reporter)

Updated

5 years ago
Depends on: 834541
(Reporter)

Updated

5 years ago
Depends on: 834543
(Reporter)

Updated

5 years ago
No longer depends on: 700250
(Reporter)

Updated

5 years ago
Depends on: 561450
(Reporter)

Updated

5 years ago
Depends on: 846635
(Reporter)

Updated

5 years ago
Depends on: 846636
(Reporter)

Updated

5 years ago
Depends on: 846644
Depends on: 854925
Depends on: 854927
Depends on: 860625

Updated

5 years ago
Depends on: 870581
No longer depends on: 870581
No longer blocks: 648232
Depends on: 885247
(Reporter)

Updated

4 years ago
Blocks: 950073
Whiteboard: [snappy:p1] → [snappy:p1][triage]

Updated

4 years ago
Whiteboard: [snappy:p1][triage] → [snappy:p1]

Updated

4 years ago
Whiteboard: [snappy:p1] → [snappy:p1] [tracking]
(Reporter)

Updated

4 years ago
Blocks: 975979

Updated

4 years ago
No longer blocks: 950073
(Reporter)

Updated

3 years ago
No longer blocks: 699820
(Reporter)

Updated

3 years ago
Depends on: 1089332
(Reporter)

Updated

3 years ago
Depends on: 1090312
(Reporter)

Updated

3 years ago
No longer depends on: 1089332
(Reporter)

Updated

3 years ago
Depends on: 1090961
(Reporter)

Updated

3 years ago
Depends on: 1091851
(Reporter)

Updated

2 years ago
Priority: -- → P1
(Reporter)

Updated

2 years ago
Keywords: perf
(Reporter)

Updated

8 months ago
Depends on: 1350377
(Reporter)

Updated

8 months ago
Depends on: 1354531
Whiteboard: [snappy:p1] [tracking] → [snappy:p1] [tracking][qf:meta]
(Reporter)

Updated

6 months ago
Depends on: 1365913
(Reporter)

Updated

6 months ago
Priority: P1 → P5
Summary: Refactor all synchronous history APIs to use async Storage APIs → [meta] Refactor all synchronous history APIs to use async Storage APIs
You need to log in before you can comment on or make changes to this bug.