615301 - remove the build-tools package from opsi/puppet and blow away dir

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

buildbot-tac.py is the only thing that is used in /tools/build-tools, which is installed by this package.  This makes it pretty fiddly to upgrade the script, and there's no reason to build a package for a simple python script.

Bug 611149 will remove the need for this package, at which point we should remove the package and delete the directory it installs into.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Changing to depend on the dynamic slave alloc bug, in hopes that it will involve removing buildbot-tac.py.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I think this is ready to do now - win64 isn't in OPSI, so it doesn't block this bug.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m615301-puppet-manifests-p1-r1.patch

Ben, how confident are you that we don't use things under /tools/build-tools for other purposes?  A check of the build-central MXR doesn't reveal anything obvious:
  http://mxr.mozilla.org/build-central/search?string=build-tools

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Huh, I'm not sure *where* this is installed with OPSI.  I guess we can just let it die.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m615301-rpm-sources-p1-r1.patch

Comment 6

[[e-mail] (:bhearsum)]

(In reply to comment #4)
> Huh, I'm not sure *where* this is installed with OPSI.  I guess we can just
> let it die.

It's installed on the Windows build machines, to d:\tools:
D:\>dir tools
 Volume in drive D is tools
 Volume Serial Number is 048A-CE48

 Directory of D:\tools

02/23/2010  03:12 PM    <DIR>          .
02/23/2010  03:12 PM    <DIR>          ..
02/23/2010  03:12 PM    <DIR>          .hg
02/23/2010  03:12 PM             3,633 .hgtags
02/23/2010  03:12 PM    <DIR>          breakpad
02/23/2010  03:12 PM    <DIR>          buildbot-helpers
02/23/2010  03:12 PM    <DIR>          buildfarm
02/23/2010  03:12 PM    <DIR>          cdmaker
02/23/2010  03:12 PM    <DIR>          clobberer
02/23/2010  03:12 PM    <DIR>          release
02/23/2010  03:12 PM    <DIR>          stage
               1 File(s)          3,633 bytes
              10 Dir(s)  18,198,835,200 bytes free


(In reply to comment #3)
> Created attachment 542350 [details] [diff] [review] [review]
> m615301-puppet-manifests-p1-r1.patch
> 
> Ben, how confident are you that we don't use things under /tools/build-tools
> for other purposes?  A check of the build-central MXR doesn't reveal
> anything obvious:
>   http://mxr.mozilla.org/build-central/search?string=build-tools

I don't know of anything else on POSIX machines that uses /tools/build-tools. On Windows, the OPSI host key generator (http://hg.mozilla.org/build/opsi-package-sources/file/fcce4578d03f/hostkey-generator/CLIENT_DATA/hostkey.ins) uses d:\tools to reset the host key in fresh clones.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Both are landed, and puppet servers restarted.