615403 - Discovery Pane Details Tweaks

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Description

[Justin Scott [:fligtar]]

Look out, it's a tweaks bug!

https://addons.allizom.org/en-US/firefox/discovery/addon/2848/

* clicking Add to Firefox opens in a new tab. it should not
* src= params on this page should be discovery-pane-details
* clicking the arrows in the preview carousel opens the main page because the base is the top level domain instead of the current page
* 174 reviews link next to stars rating should go to same place as the bottom reviews link
* the carousel arrows should be hidden or disabled if they aren't usable. this seems to work properly once you start rotating but not by default on page load
* details page URLs don't work without a trailing slash, e.g. https://addons.allizom.org/en-US/firefox/discovery/addon/966

* on add-ons with EULAs (https://addons.allizom.org/en-US/firefox/discovery/addon/966/) the install button says Accept and Install and goes to install the add-on instead of the EULA page. the button should only say Accept and Install on the EULA page

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/30ba276

Comment 2

[Justin Scott [:fligtar]]

Thanks.

I still see a right arrow on https://addons.allizom.org/en-US/firefox/discovery/addon/2848/ that opens a new tab when I click it.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Fixed in commit https://github.com/jbalogh/zamboni/commit/23508d0

Comment 4

[krupa raj[:krupa]]

> * details page URLs don't work without a trailing slash, e.g.
> https://addons.allizom.org/en-US/firefox/discovery/addon/966

I can still reproduce this problem

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> > * details page URLs don't work without a trailing slash, e.g.
> > https://addons.allizom.org/en-US/firefox/discovery/addon/966
> 
> I can still reproduce this problem

http://github.com/jbalogh/zamboni/commit/0c2b05d