615556 - Animated adjoining unselected tabs overlap each other when closing

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[David Hsu]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101130 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101130 Firefox/4.0b8pre

When closing two or more adjoining unselected tabs, the closed tab will move left and overlap onto the one left to it near the end of the animation. 

(Might be that unselected tabs don't have a background color, but I think it shouldn't even move left.)

Reproducible: Always

Steps to Reproduce:
1. Open up at least three tabs.
2. Focus the rightmost one so that the 1st and 2nd tab remain inactive.
3. Close the 2nd tab and watch the animation.

Comment 1

[David Hsu]

Attachment: Screenshot

Comment 2

[David Hsu]

Attachment: Screenshot 2

Another scenario: 
1. Open up enough tabs so that they stack up and start to shrink in width.
2. Focus any tab other than the last two.
3. Close the rightmost one.

Comment 3

[Markus Stange [:mstange]]

Attachment: v1

Comment 4

[Markus Stange [:mstange]]

Attachment: video after patch

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 503545 [details] [diff] [review]
v1

>+/* Prevent overlapping of tabs during the close animation */
>+.tabbrowser-tab:not([fadein]):not([pinned]) {
>+  -moz-transition: min-width 200ms ease-out,
>+                   max-width 250ms ease-out,
>+                   opacity 50ms ease-out 100ms;
>+}

Why does pinstripe need a different offset for the opacity transition? If this works better, wouldn't it work better for other themes too?

Comment 6

[Markus Stange [:mstange]]

Attachment: v2

Probably. I didn't just want to overwrite the numbers you came up with in bug 604735 because I've only tested it on Mac. But I guess there's not much I can break here.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 503555 [details] [diff] [review]
v2

a=beltzner

Comment 8

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/433213256ed1