Closed Bug 615556 Opened 9 years ago Closed 9 years ago

Animated adjoining unselected tabs overlap each other when closing

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: illusionmist62442, Assigned: mstange)

References

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101130 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101130 Firefox/4.0b8pre

When closing two or more adjoining unselected tabs, the closed tab will move left and overlap onto the one left to it near the end of the animation. 

(Might be that unselected tabs don't have a background color, but I think it shouldn't even move left.)

Reproducible: Always

Steps to Reproduce:
1. Open up at least three tabs.
2. Focus the rightmost one so that the 1st and 2nd tab remain inactive.
3. Close the 2nd tab and watch the animation.
Attached image Screenshot
Blocks: 547787
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Hardware: x86 → All
Version: unspecified → Trunk
Attached image Screenshot 2
Another scenario: 
1. Open up enough tabs so that they stack up and start to shrink in width.
2. Focus any tab other than the last two.
3. Close the rightmost one.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #503545 - Flags: review?(dao)
Attached video video after patch
Comment on attachment 503545 [details] [diff] [review]
v1

>+/* Prevent overlapping of tabs during the close animation */
>+.tabbrowser-tab:not([fadein]):not([pinned]) {
>+  -moz-transition: min-width 200ms ease-out,
>+                   max-width 250ms ease-out,
>+                   opacity 50ms ease-out 100ms;
>+}

Why does pinstripe need a different offset for the opacity transition? If this works better, wouldn't it work better for other themes too?
Attached patch v2Splinter Review
Probably. I didn't just want to overwrite the numbers you came up with in bug 604735 because I've only tested it on Mac. But I guess there's not much I can break here.
Attachment #503545 - Attachment is obsolete: true
Attachment #503555 - Flags: review?(dao)
Attachment #503545 - Flags: review?(dao)
Attachment #503555 - Flags: review?(dao) → review+
Attachment #503555 - Flags: approval2.0?
Comment on attachment 503555 [details] [diff] [review]
v2

a=beltzner
Attachment #503555 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/433213256ed1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
Depends on: 718228
You need to log in before you can comment on or make changes to this bug.