tab close transition to transparent is too fast

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: asa, Assigned: dao)

Tracking

Trunk
Firefox 12
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 588688 [details]
animation showing the too fast transition to transparent

When you close a tab, the tab animates sliding leftward and becoming transparent. The transition from opaque to transparent happens far too quickly leading to a totally transparent tab well before the tab has collapsed. This makes the new tab button (or the tab to the right of the closing tab) appear to be "slow" or "not keeping up" with the closing tab.  This needs to be adjusted so that there is not a "gap" between the tab left of the closing tab and the tab (or new tab button) right of the closing tab. See attached slow-motion view to understand better what's going on. (note, my screen capture software isn't getting 60fps here so some intermediate stages are dropped, but you should be able to see what's going on.)
(Assignee)

Updated

6 years ago
Blocks: 615556
(Assignee)

Updated

6 years ago
Assignee: nobody → dao
(Assignee)

Comment 1

6 years ago
Created attachment 588847 [details] [diff] [review]
patch
Attachment #588847 - Flags: review?(mak77)
Attachment #588847 - Flags: feedback?(jwein)
Created attachment 588981 [details]
animation showing the patch applied

This is an animation of the patch applied, recorded at 60fps and then slowed down to 25% of the speed.
Comment on attachment 588847 [details] [diff] [review]
patch

I've tested this out on Windows and it looks much better than before.
Attachment #588847 - Flags: feedback?(jwein) → feedback+
(Reporter)

Comment 4

6 years ago
so much nicer. thanks for taking this up so quickly!
(Assignee)

Comment 5

6 years ago
Comment on attachment 588847 [details] [diff] [review]
patch

not sure if mak is around...
Attachment #588847 - Flags: review?(ttaubert)
Comment on attachment 588847 [details] [diff] [review]
patch

Review of attachment 588847 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +1704,5 @@
>  
> +.tabbrowser-tab:not([pinned]):not([fadein]) {
> +  -moz-transition: min-width 200ms ease-out /* copied from browser/base/content/browser.css */,
> +                   max-width 250ms ease-out /* copied from browser/base/content/browser.css */,
> +                   opacity 50ms ease-out 100ms /* hide the tab for the last 100ms of the max-width transition */;

Do the extra 80ms that the tab is hidden make sure we don't regress bug 615556?
(Assignee)

Comment 7

6 years ago
Yep, that's the idea.
Comment on attachment 588847 [details] [diff] [review]
patch

Review of attachment 588847 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, just wanted to make sure I got that right. Looks good to me.
Attachment #588847 - Flags: review?(ttaubert) → review+
(Assignee)

Updated

6 years ago
Attachment #588847 - Flags: review?(mak77)
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a79c86c93925
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/a79c86c93925
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.