Closed
Bug 615953
Opened 14 years ago
Closed 14 years ago
REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/421710-1.html | assertion count 4 is more than expected 0 assertions
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: dbaron)
References
Details
We just started running Win7 debug unit tests and there is currently a permanent orange for reftests (https://bugzilla.mozilla.org/show_bug.cgi?id=614956#c5). > REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central_win7-debug_test-reftest/build/reftest/tests/layout/reftests/bugs/421710-1.html | assertion count 4 is more than expected 0 assertions We need to fix this before we can do the switchover from running _debug_ unit tests on the Win2003 machines to the Win7 Rev3 machines. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291229629.1291233026.3919.gz
Reporter | ||
Comment 1•14 years ago
|
||
I believe the test was written in bug 421710 and I am adding few people from that original bug.
Assignee | ||
Comment 2•14 years ago
|
||
It's four occurrences of: ###!!! ASSERTION: Two floats with same parent in same floats list, expect weird errors.: 'c == f || c->GetParent() != this || !mFloats.ContainsFrame(c)', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/layout/generic/nsBlockFrame.cpp, line 4530
Assignee | ||
Comment 3•14 years ago
|
||
The test is currently marked: asserts-if(gtk2Widget,4) != 421710-1.html about:blank # assertion test (and crash test), asserts are bug 602426. We should probably just change it to asserts(0-4), since it's probably something size-dependent.
Assignee | ||
Comment 4•14 years ago
|
||
I put a patch to do that in my patch queue; I'll land it next time I push.
Assignee: nobody → dbaron
Comment 5•14 years ago
|
||
(In reply to comment #3) > We should probably just change it to asserts(0-4) Or perhaps: asserts-if(gtk2Widget,4) asserts-if(winWidget,0-4) so that we can tell (at least on Linux) if the assertions go away?
Updated•14 years ago
|
Summary: REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central_win7-debug_test-reftest/build/reftest/tests/layout/reftests/bugs/421710-1.html | assertion count 4 is more than expected 0 assertions → REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/421710-1.html | assertion count 4 is more than expected 0 assertions
Comment 6•14 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Places/1291344756.1291348252.28539.gz
Comment 7•14 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Places/1291385282.1291388488.29962.gz
Assignee | ||
Comment 8•14 years ago
|
||
Landed with dholbert's suggestion (which is less correct but more useful): http://hg.mozilla.org/mozilla-central/rev/ec5b2fab7df5
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•14 years ago
|
||
Gracias! :)
You need to log in
before you can comment on or make changes to this bug.
Description
•