Closed Bug 616020 Opened 9 years ago Closed 9 years ago

Use armeabi-v7a for thumb2 builds on Android

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
This patch makes our APK package specify armeabi-v7a in Thumb-2 builds.  This will let us prevent the Android Market from offer Fennec to incompatible (ARMv6) devices.

We didn't do this before because we were concerned that it wouldn't work on Android 2.1 and earlier.  However, I tested and found that armeabi-v7a packages do work on the compatible Android 2.1 devices that I'm aware of (Xperia X10 and Galaxy S).

This mailing list thread indicates that there *were* problems with armeabi-v7a in Eclair on the Desire and Milestone.  However, the thread confirms that the problem was fixed in an OTA update on the Desire, and we tested and found that it is fixed in the latest OS on the Milestone:
http://groups.google.com/group/android-ndk/browse_thread/thread/464bab5543c672d4
Attachment #494550 - Flags: review?(mwu)
This should block Fennec beta 3, if we plan to upload b3 to the Market.
tracking-fennec: --- → ?
Comment on attachment 494550 [details] [diff] [review]
patch

Normally I'd ask a build peer, but I think I actually own all of the code here, so r=mwu should be enough.

We'll want to follow up with a patch to rip out the cpu detection code in the java wrapper.
Attachment #494550 - Flags: review?(mwu) → review+
One downside of this patch:  Users who download an ARMv7 build to an ARMv6 device (not from the market, but directly from ftp.mozilla.org or elsewhere) get a very un-helpful error screen from the Android package installer: "Not installed"
tracking-fennec: ? → 2.0b3+
Attachment #494550 - Attachment is obsolete: true
Attachment #494627 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/75d91c4ff0d8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Notes for testing: See comment 3, the error message has changed when you try to install an ARMv7 build on an ARMv6 device.
One more note for testing: If you are using a tegra board you must update the os image to the latest dated 20101105.
Blocks: 617181
You need to log in before you can comment on or make changes to this bug.