Closed Bug 617181 Opened 9 years ago Closed 9 years ago

Remove CPU detection code from Java wrapper

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: [fennec-checkin-postb3])

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #616020 +++

Since bug 616020 landed, the OS will prevent our ARMv7 builds from being installed on non-ARMv7 devices.  The code we wrote to do this will no longer be used, and can be removed.

I didn't remove the MOZ_MIN_CPU_VERSION symbol completely, because it's still used to annotate crash reports.
Attachment #495681 - Flags: review?(mwu)
tracking-fennec: 2.0b3+ → ---
Comment on attachment 495681 [details] [diff] [review]
patch

Victory at last.

The incompatable_cpu_error string can also be removed. (er, damn, I never noticed the typo..)
Attachment #495681 - Flags: review?(mwu) → review+
Attachment #495681 - Attachment is obsolete: true
Attachment #495684 - Flags: review+
Attachment #495684 - Flags: approval2.0?
Requesting approval2.0; this patch just removes no-longer-used code.
Whiteboard: [fennec-checkin-postb3]
can the apk be installed on ARMv6 devices running eclar?
(In reply to comment #4)
> can the apk be installed on ARMv6 devices running eclar?

No - the OS will give an INSTALL_FAILED_INVALID_APK error and display a "Not Installed" dialog.  (Tested on the Android SDK emulator running Android 2.1.)
Attachment #495684 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/befa46c6032a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.