617181 - Remove CPU detection code from Java wrapper

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #616020 +++

Since bug 616020 landed, the OS will prevent our ARMv7 builds from being installed on non-ARMv7 devices.  The code we wrote to do this will no longer be used, and can be removed.

I didn't remove the MOZ_MIN_CPU_VERSION symbol completely, because it's still used to annotate crash reports.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 495681 [details] [diff] [review]
patch

Victory at last.

The incompatable_cpu_error string can also be removed. (er, damn, I never noticed the typo..)

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch for checkin

Comment 3

[Matt Brubeck (:mbrubeck)]

Requesting approval2.0; this patch just removes no-longer-used code.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

can the apk be installed on ARMv6 devices running eclar?

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> can the apk be installed on ARMv6 devices running eclar?

No - the OS will give an INSTALL_FAILED_INVALID_APK error and display a "Not Installed" dialog.  (Tested on the Android SDK emulator running Android 2.1.)

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/befa46c6032a