Closed Bug 616110 Opened 10 years ago Closed 10 years ago

"Error: undefined entity // panels.rdf // sidebar.search.label" on profile first use

Categories

(SeaMonkey :: Sidebar, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: sgautherie, Assigned: Manuel.Spam)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

[Mozilla/5.0 (Windows NT 5.0; rv:2.0b8pre) Gecko/20101127 Firefox/4.0b8pre SeaMonkey/2.1b2pre] (comm-central-trunk-win32/1290878667)

I'm running some mochitests, like bug 615923,
and the Error Console reports:
{
Error: undefined entity
Source File: file:///c:/docume~1/na/locals~1/temp/tmpimxxgu/panels.rdf
Line: 25, Column: 15
Source Code:
    <NC:title>&sidebar.search.label;</NC:title>
}

I assume this is a regression from bug 399310, though I haven't verified that.
blocking-seamonkey2.1: --- → ?
[Mozilla/5.0 (Windows NT 5.0; rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre SeaMonkey/2.1b2pre] (nightly)

This happens once for every new profile.
(and test suites create temporary profiles...)
Severity: normal → major
Summary: mochitests: "Error: undefined entity // panels.rdf // sidebar.search.label" → "Error: undefined entity // panels.rdf // sidebar.search.label" on profile first use
Attached patch Patch (obsolete) — Splinter Review
In the process of moving away from the RDF-based sidebar code, "local-panels.dtd" has been dropped and the entities have been moved to "sidebarOverlay.dtd". A simple one-line fix is attached. Serge, could you please try if this fixes this error?
Assignee: nobody → Manuel.Spam
Attachment #496152 - Flags: feedback?(sgautherie.bz)
Attachment #496152 - Flags: review?(mnyromyr)
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.1b2
Attachment #496152 - Flags: review?(mnyromyr)
Dropped review request. Sorry for poaching, but I have another patch in work.

IMHO what we do here is duplicating information. The new "sync from broadcaster to RDF algorithm" should be able to auto-generate most of this panels.rdf template file. I still have to debug my patch, but it will reduce this file to almost only the include of the "panels.extra" file.
If panels.extra doesn't work correctly (i.e. including more panels through L10n) or causes too much overhead in terms of work, then if it's little work, let's get a different L10n inclusion mechanism in or drop it completely. I think de is the only locale using it anyhow, and that sidebar isn't that interesting that it warrants a lot of maintenance work.
(In reply to comment #4)
> Dropped review request. Sorry for poaching, but I have another patch in work.

Yet, I wouldn't mind fixing what we have atm...
I can't remove the file completely, as this causes the current RDF code to fail and I don't want to change too much there, as I hope it'll be removed soon (see Bug 613971). As I have to keep the file to not make the code fail, I'll also keep panels.extra.

In (hopefully near) future this whole mechanism will be gone and the only way to add a sidebar will be a bookmark with "open in sidebar" checkbox checked.
This patch just drops all that stuff, we in fact not need anymore. Unfortunately this triggers Bug 618860 on Linux as "Bookmarks" is our first broadcaster and so is the default panel...

As it's also possible to trigger Bug 618860 without this patch, I think it's ok to ask for review.
Attachment #496152 - Attachment is obsolete: true
Attachment #497284 - Flags: superreview?(mnyromyr)
Attachment #497284 - Flags: review?(mnyromyr)
OS: Windows 2000 → All
Hardware: x86 → All
Depends on: 618860
Comment on attachment 497284 [details] [diff] [review]
Patch, fixing this bug by dropping obsolete stuff from panels.rdf.in
[Checked in: Comment 10]

No sr needed (I think).
Attachment #497284 - Flags: superreview?(mnyromyr)
Attachment #497284 - Flags: review?(mnyromyr)
Attachment #497284 - Flags: review+
Keywords: checkin-needed
Comment on attachment 497284 [details] [diff] [review]
Patch, fixing this bug by dropping obsolete stuff from panels.rdf.in
[Checked in: Comment 10]

http://hg.mozilla.org/comm-central/rev/97da7450f2a0
Attachment #497284 - Attachment description: Patch, fixing this bug by dropping obsolete stuff from panels.rdf.in → Patch, fixing this bug by dropping obsolete stuff from panels.rdf.in [Checked in: Comment 10]
Status: ASSIGNED → RESOLVED
blocking-seamonkey2.1: ? → ---
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.