Last Comment Bug 616137 - Failing to parse attribute selector should skip to the next ']'
: Failing to parse attribute selector should skip to the next ']'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P1 normal (vote)
: mozilla5
Assigned To: Boris Zbarsky [:bz] (still a bit busy)
:
: Jet Villegas (:jet)
Mentors:
Depends on: 651266
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-02 08:18 PST by Boris Zbarsky [:bz] (still a bit busy)
Modified: 2011-04-20 05:01 PDT (History)
1 user (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Skip to the nearest ']' when parsing an attr selector fails. (3.69 KB, patch)
2010-12-02 08:45 PST, Boris Zbarsky [:bz] (still a bit busy)
dbaron: review+
dbaron: approval2.0-
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] (still a bit busy) 2010-12-02 08:18:39 PST
Patch + test coming up
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2010-12-02 08:45:54 PST
Created attachment 494728 [details] [diff] [review]
Skip to the nearest ']' when parsing an attr selector fails.
Comment 2 David Baron :dbaron: ⌚️UTC-10 2010-12-02 13:07:17 PST
Comment on attachment 494728 [details] [diff] [review]
Skip to the nearest ']' when parsing an attr selector fails.

r=dbaron
Comment 3 David Baron :dbaron: ⌚️UTC-10 2011-01-14 17:55:02 PST
Comment on attachment 494728 [details] [diff] [review]
Skip to the nearest ']' when parsing an attr selector fails.

I think we should hold this until the next cycle; we're often surprised by things that break as a result of parsing quirks.
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2011-03-04 09:08:20 PST
http://hg.mozilla.org/projects/birch/rev/52e34cbb1d4e
Comment 5 David Baron :dbaron: ⌚️UTC-10 2011-03-23 13:52:37 PDT
https://hg.mozilla.org/mozilla-central/rev/52e34cbb1d4e

Note You need to log in before you can comment on or make changes to this bug.