Last Comment Bug 616353 - Make DOM constants constant.
: Make DOM constants constant.
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Johnny Stenback (:jst,
Depends on: 765177
  Show dependency treegraph
Reported: 2010-12-02 17:08 PST by Johnny Stenback (:jst,
Modified: 2012-06-21 06:12 PDT (History)
9 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix. (736 bytes, patch)
2010-12-03 09:14 PST, Johnny Stenback (:jst,
peterv: review+
Details | Diff | Review

Description Johnny Stenback (:jst, 2010-12-02 17:08:39 PST
This came up in an email thread recently where WebKit apparently makes DOM constants (i.e. Node.ELEMENT_NODE etc) be readonly properties and Firefox and IE do not. Seems there's no reason for this, and constants should be constant, so we should fix this. Probably too late to fix for Firefox 4 though.
Comment 1 Johnny Stenback (:jst, 2010-12-03 09:14:13 PST
Created attachment 495017 [details] [diff] [review]
Comment 2 :Ms2ger 2011-11-02 07:30:45 PDT
Johnny, did you lose track of this bug?
Comment 3 Olli Pettay [:smaug] 2011-11-02 07:57:51 PDT
This needs some tests.
Comment 4 :Ms2ger 2012-01-08 10:20:51 PST
I'll get some tests imported in bug 647323.
Comment 5 :Ms2ger 2012-06-16 05:19:06 PDT
(In reply to :Ms2ger from comment #4)
> I'll get some tests imported in bug 647323.

That didn't work out, but I'm getting them in bug 765177. I'll land this patch when I push that.

Note You need to log in before you can comment on or make changes to this bug.