Make DOM constants constant.

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
This came up in an email thread recently where WebKit apparently makes DOM constants (i.e. Node.ELEMENT_NODE etc) be readonly properties and Firefox and IE do not. Seems there's no reason for this, and constants should be constant, so we should fix this. Probably too late to fix for Firefox 4 though.
(Assignee)

Comment 1

7 years ago
Created attachment 495017 [details] [diff] [review]
Fix.
Attachment #495017 - Flags: review?(peterv)
Attachment #495017 - Flags: review?(peterv) → review+
Johnny, did you lose track of this bug?
Assignee: nobody → jst

Comment 3

6 years ago
This needs some tests.
I'll get some tests imported in bug 647323.
Depends on: 647323
(In reply to :Ms2ger from comment #4)
> I'll get some tests imported in bug 647323.

That didn't work out, but I'm getting them in bug 765177. I'll land this patch when I push that.
Depends on: 765177
No longer depends on: 647323
https://hg.mozilla.org/mozilla-central/rev/909962db6b8a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.