The default bug view has changed. See this FAQ.

Import some more tests

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 633460 [details] [diff] [review]
Part a: Update WebStorage
Attachment #633460 - Flags: review?(bzbarsky)
(Assignee)

Comment 1

5 years ago
Created attachment 633461 [details] [diff] [review]
Part b (1): Import approved DOMCore tests
Attachment #633461 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Created attachment 633462 [details] [diff] [review]
Part b (2): Add expected failures for approved DOMCore tests
Attachment #633462 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

5 years ago
Created attachment 633463 [details] [diff] [review]
Part c (1): Import XHR tests
Attachment #633463 - Flags: review?(bzbarsky)
(Assignee)

Comment 4

5 years ago
Created attachment 633464 [details] [diff] [review]
Part c (2): Add expected failures for XHR tests
Attachment #633464 - Flags: review?(bzbarsky)
(Assignee)

Comment 5

5 years ago
Created attachment 633465 [details] [diff] [review]
Part c (2): Add expected failures for XHR tests

Right patch
Attachment #633464 - Attachment is obsolete: true
Attachment #633464 - Flags: review?(bzbarsky)
Attachment #633465 - Flags: review?(bzbarsky)
Comment on attachment 633460 [details] [diff] [review]
Part a: Update WebStorage

r=me
Attachment #633460 - Flags: review?(bzbarsky) → review+
Comment on attachment 633461 [details] [diff] [review]
Part b (1): Import approved DOMCore tests

r=me
Attachment #633461 - Flags: review?(bzbarsky) → review+
Comment on attachment 633462 [details] [diff] [review]
Part b (2): Add expected failures for approved DOMCore tests

I'm not going to ask for bug numbers in the actual files here, but I assume bugs _are_ filed for this stuff?
Attachment #633462 - Flags: review?(bzbarsky) → review+
Comment on attachment 633463 [details] [diff] [review]
Part c (1): Import XHR tests

r=me
Attachment #633463 - Flags: review?(bzbarsky) → review+
Comment on attachment 633465 [details] [diff] [review]
Part c (2): Add expected failures for XHR tests

Again, bugs filed?
Attachment #633465 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 11

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #8)
> Comment on attachment 633462 [details] [diff] [review]
> Part b (2): Add expected failures for approved DOMCore tests
> 
> I'm not going to ask for bug numbers in the actual files here, but I assume
> bugs _are_ filed for this stuff?

Everything to do with detached ranges is bug 702948, everything about the `how` argument to compareBoundaryPoints is bug 714279, intersectsNode is bug 579638, and I'm going to say bug 580070 for interfaces.html.
(Assignee)

Comment 12

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #10)
> Comment on attachment 633465 [details] [diff] [review]
> Part c (2): Add expected failures for XHR tests
> 
> Again, bugs filed?

"existence and properties of interface prototype object": bug 764539
TypeError: bug 765464
FormData: bug 580070
FormData.append: bug 739174
(Assignee)

Updated

5 years ago
Blocks: 616353
(Assignee)

Comment 13

5 years ago
Comment on attachment 633460 [details] [diff] [review]
Part a: Update WebStorage

https://hg.mozilla.org/mozilla-central/rev/bd2070d6ec27

The Range-insertNode test appears to fail on 64-bit opt builds :/
Attachment #633460 - Flags: checkin+
(Assignee)

Updated

5 years ago
Depends on: 765799
(Assignee)

Comment 14

5 years ago
Aryeh fixed that issues; landed the tests:

https://hg.mozilla.org/mozilla-central/rev/caf8e1be4566
https://hg.mozilla.org/mozilla-central/rev/88272202e6c5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Comment 15

5 years ago
is it possible that this broke pymake builds? My pymake build is failing as follows:

nsinstall: ..\..\..\..\..\..\..\..\..\..\mozilla\dom\imptests\failures\webapps\X
MLHttpRequest\tests\submissions\Ms2ger\test_setrequestheader-invalid-arguments.h
tm.json: No such file or directory
c:\builds\tbnew\objdir-tb\mozilla\dom\imptests\failures\webapps\XMLHttpRequest\t
ests\submissions\Ms2ger\Makefile:20:0: command 'c:/builds/tbnew/objdir-tb/mozill
a/config/nsinstall.exe "../../../../../../../../../../mozilla/dom/imptests/failu
res/webapps/XMLHttpRequest/tests/submissions/Ms2ger/test_interfaces.html.json" "
../../../../../../../../../../mozilla/dom/imptests/failures/webapps/XMLHttpReque
st/tests/submissions/Ms2ger/test_setrequestheader-invalid-arguments.htm.json" ..
/../../../../../../../_tests/testing/mochitest/tests/dom/imptests/failures/webap
ps/XMLHttpRequest/tests/submissions/Ms2ger' failed, return code 3
H:\mozdev\mozilla-central\obj-i686-pc-mingw32\dom\imptests\failures\webapps\XMLHttpRequest\tests\submissions\Ms2ger\..\..\..\..\..\..\..\..\..\dom\imptests\failures\webapps\XMLHttpRequest\tests\submissions\Ms2ger\test_setrequestheader-invalid-arguments.htm.json
is longer than 260 (= MAX_PATH) characters.
Pymake builds are broken for me too. Same error
If I shorten the folder name (H:\mozdev -> H:\m), pymake build works.
Depends on: 776493
You need to log in before you can comment on or make changes to this bug.