Address Book Output Panel does not read (or overrides) GTK theme settings for background, text color.

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
UI Design
--
minor
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: skyalmian, Assigned: skyalmian)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.17pre) Gecko/20101201 SeaMonkey/2.0.12pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.17pre) Gecko/20101201 SeaMonkey/2.0.12pre

While the Address Book's list of contacts and address book panels (top row and left column) adhere to whatever setting the GTK theme is set to, namely text and background color, the output panel below overrides with white background and white text. This is only noticeable on dark GTK themes with black backgrounds and white or gray text.

Reproducible: Always

Steps to Reproduce:
1. Switch to a dark-themed GTK theme where black backgrounds are the norm.



A screenshot for visual example:
http://sky.sploitz.com/bugzilla/seamonkey-address-book.png

Comment 1

7 years ago
This looks like the SeaMonkey equivalent of Thunderbird bug 351736?
Address book backend is shared code, but the themes aren't...
(Assignee)

Comment 2

7 years ago
Yep... I incorporated the changes into addressbook.css from "Comment on attachment 375176 [details] [diff] [review]" and tested... Like Brian said: "looks good", with and without dark GTK theme. "The fix v2" needs to be incorporated into addressbook.css.

Comment 3

7 years ago
Since you've worked it out already, do you like to post a patch for review? :-D
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 4

7 years ago
Created attachment 495309 [details] [diff] [review]
Patch

I've never done any actual coding before and this is first time doing anything... Does this count?
(Assignee)

Updated

7 years ago
Component: MailNews: Address Book & Contacts → UI Design
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk

Comment 5

7 years ago
Comment on attachment 495309 [details] [diff] [review]
Patch

Looks good to me, I'm asking Neil for review on your behalf.
Attachment #495309 - Attachment description: Patch? → Patch
Attachment #495309 - Attachment is patch: true
Attachment #495309 - Flags: review?(neil)

Updated

7 years ago
Assignee: nobody → skyalmian
Status: NEW → ASSIGNED

Comment 6

7 years ago
Comment on attachment 495309 [details] [diff] [review]
Patch

> .CardViewLink {
>-  color: blue;
>-  text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
Why are you removing the underlining?

Comment 7

7 years ago
The Thunderbird themes have "text-decoration: underline;" defined later as part of the "html|a" rules, SeaMonkey's classic theme doesn't have that.

Comment 8

7 years ago
Comment on attachment 495309 [details] [diff] [review]
Patch

> .CardViewLink {
>-  color: blue;
>-  text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
r=me if you restore the underlining.
Attachment #495309 - Flags: review?(neil) → review+
(Assignee)

Comment 9

7 years ago
Created attachment 495413 [details] [diff] [review]
"hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]

Re-added the line...
Attachment #495309 - Attachment is obsolete: true

Updated

7 years ago
Attachment #495413 - Attachment is patch: true

Comment 10

7 years ago
This should be approved after Neil's r+, unless I'm reading anything wrong.
Thus, I'm setting the "checkin-needed" keyword for someone to push on trunk.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
(Assignee)

Comment 11

7 years ago
Thank you for everything you've done... This wouldn't have been solved had you not found the similar Thunderbird bug. :} I did look before posting this, but I had limited my searches to SeaMonkey...

Comment 12

7 years ago
You are welcome, and congratulations for your first SeaMonkey patch!

Updated

7 years ago
Attachment #495413 - Attachment description: "hg diff -p -U 8 addressbook.css > addressbook2.txt" output → "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil
Attachment #495413 - Flags: review+

Comment 13

6 years ago
I'm not aware of any tree closures on trunk, thus a friendly ping for a push?
Comment on attachment 495413 [details] [diff] [review]
"hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]

http://hg.mozilla.org/comm-central/rev/1e36326c45e3
Attachment #495413 - Attachment description: "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil → "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]
Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.1b2
Comment on attachment 495413 [details] [diff] [review]
"hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]

> .CardViewLink {
>-  color: blue;
>   text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
[The slip over the underline has caused the change in colour to migrate!]
You need to log in before you can comment on or make changes to this bug.