Closed Bug 616699 Opened 10 years ago Closed 10 years ago

Address Book Output Panel does not read (or overrides) GTK theme settings for background, text color.

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: skyalmian, Assigned: skyalmian)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.17pre) Gecko/20101201 SeaMonkey/2.0.12pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.17pre) Gecko/20101201 SeaMonkey/2.0.12pre

While the Address Book's list of contacts and address book panels (top row and left column) adhere to whatever setting the GTK theme is set to, namely text and background color, the output panel below overrides with white background and white text. This is only noticeable on dark GTK themes with black backgrounds and white or gray text.

Reproducible: Always

Steps to Reproduce:
1. Switch to a dark-themed GTK theme where black backgrounds are the norm.



A screenshot for visual example:
http://sky.sploitz.com/bugzilla/seamonkey-address-book.png
This looks like the SeaMonkey equivalent of Thunderbird bug 351736?
Address book backend is shared code, but the themes aren't...
Yep... I incorporated the changes into addressbook.css from "Comment on attachment 375176 [details] [diff] [review]" and tested... Like Brian said: "looks good", with and without dark GTK theme. "The fix v2" needs to be incorporated into addressbook.css.
Since you've worked it out already, do you like to post a patch for review? :-D
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Patch (obsolete) — Splinter Review
I've never done any actual coding before and this is first time doing anything... Does this count?
Component: MailNews: Address Book & Contacts → UI Design
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 495309 [details] [diff] [review]
Patch

Looks good to me, I'm asking Neil for review on your behalf.
Attachment #495309 - Attachment description: Patch? → Patch
Attachment #495309 - Attachment is patch: true
Attachment #495309 - Flags: review?(neil)
Assignee: nobody → skyalmian
Status: NEW → ASSIGNED
Comment on attachment 495309 [details] [diff] [review]
Patch

> .CardViewLink {
>-  color: blue;
>-  text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
Why are you removing the underlining?
The Thunderbird themes have "text-decoration: underline;" defined later as part of the "html|a" rules, SeaMonkey's classic theme doesn't have that.
Comment on attachment 495309 [details] [diff] [review]
Patch

> .CardViewLink {
>-  color: blue;
>-  text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
r=me if you restore the underlining.
Attachment #495309 - Flags: review?(neil) → review+
Re-added the line...
Attachment #495309 - Attachment is obsolete: true
Attachment #495413 - Attachment is patch: true
This should be approved after Neil's r+, unless I'm reading anything wrong.
Thus, I'm setting the "checkin-needed" keyword for someone to push on trunk.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Thank you for everything you've done... This wouldn't have been solved had you not found the similar Thunderbird bug. :} I did look before posting this, but I had limited my searches to SeaMonkey...
You are welcome, and congratulations for your first SeaMonkey patch!
Attachment #495413 - Attachment description: "hg diff -p -U 8 addressbook.css > addressbook2.txt" output → "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil
Attachment #495413 - Flags: review+
I'm not aware of any tree closures on trunk, thus a friendly ping for a push?
Comment on attachment 495413 [details] [diff] [review]
"hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]

http://hg.mozilla.org/comm-central/rev/1e36326c45e3
Attachment #495413 - Attachment description: "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil → "hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]
Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.1b2
Comment on attachment 495413 [details] [diff] [review]
"hg diff -p -U 8 addressbook.css > addressbook2.txt" output. r=Neil [Checkin: comment 14]

> .CardViewLink {
>-  color: blue;
>   text-decoration: underline;
>+  color: -moz-nativehyperlinktext;
[The slip over the underline has caused the change in colour to migrate!]
You need to log in before you can comment on or make changes to this bug.