make reddit-panel example use jQuery again

RESOLVED FIXED in 1.0b1

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

unspecified
1.0b1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cherry-pick-1.0b1])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 495328 [details] [diff] [review]
patch v1: makes change

Intrepid platform developers have found a fix for bug 614757.  And there's a reasonable chance it'll land for Firefox 4.0b8.  Once it lands, we should update the reddit-panel example to use jQuery again, and if it's not too late, we should apply the change to the 1.0b1 branch, so SDK users can see how to use jQuery as a content script.

Assuming the platform fix lands for 4.0b8, here's the SDK patch that adds jQuery back into the example.  It basically just reverts the fix for bug 615081, except that it also updates jQuery from 1.4.2 to 1.4.4, switches from contentScriptURL to contentScriptFile, and includes a README.md file that describes the addon and explains with which versions of Firefox it is compatible.
Attachment #495328 - Flags: review?(dietrich)
Attachment #495328 - Flags: review?(dietrich) → review+
(Assignee)

Comment 1

8 years ago
The platform fix landed for 4.0b8, which is scheduled to be built in a couple days and released next week.

Trunk commit:

https://github.com/mozilla/addon-sdk/commit/46b4481ef202e8d57e0a1537f6434faea77367bb

Branch cherry-pick:

https://github.com/mozilla/addon-sdk/commit/06f7a7ca122d0289887ed108a9091a1d10af8de8
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [cherry-pick-1.0b1]
(Assignee)

Comment 2

8 years ago
My branch commit was missing some files that I added in a followup commit:

https://github.com/mozilla/addon-sdk/commit/ae9631e9bc2b9abb033ea29c8a7be8300415ae11
(Assignee)

Updated

8 years ago
Blocks: 627152
You need to log in before you can comment on or make changes to this bug.