616895 - 'Runner' has no attribute 'names'

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'm not able to start a 2.0 Mozmill build right now on OS X. I always get the following stack:

  File "/Volumes/data/testing/envs/mozmill-2/bin/mozmill", line 8, in <module>
    load_entry_point('mozmill==2.0a', 'console_scripts', 'mozmill')()
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 578, in cli
    CLI(args).run()
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 549, in run
    runner = self.create_runner()
  File "/Volumes/data/build/tools/mozmill-2.0/mozrunner/mozrunner/runner.py", line 322, in create_runner
    self.runner_args())
  File "/Volumes/data/build/tools/mozmill-2.0/mozrunner/mozrunner/runner.py", line 234, in create_runner
    **runner_args)
  File "/Volumes/data/build/tools/mozmill-2.0/mozrunner/mozrunner/runner.py", line 59, in __init__
    self.binary = Runner.get_binary(binary)
  File "/Volumes/data/build/tools/mozmill-2.0/mozrunner/mozrunner/runner.py", line 83, in get_binary
    return os.path.join(binary, 'Contents/MacOS/%s-bin' % cls.names[0])
AttributeError: type object 'Runner' has no attribute 'names'

Looks like this is a fallout from bug 607264.

Comment 1

[Jeff Hammel]

Attachment: use the correct class when calling get_binary

the classmethod get_binary is currently called just as Runner.  instead, the actually class of the instance should be used

much of this code is really awful and should probably be gone over with a fine toothed code.  however, if this fixes the issue, then its at least an improvement

Comment 2

[Heather Arthur [:harth]]

https://github.com/mozautomation/mozmill/commit/d3441be945a65a002a00b569c85da87810032e78

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Heather, can you also please set r+ to the patch?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works perfect with latest revision. Marking as verified fixed.