607264 - Unbitrot patch reverts some old code in Mozmill/Mozrunner/Jsbridge on master

Status: RESOLVED INCOMPLETE

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the following check-in from Clint on Oct. 15th a couple of old code went into the master. And as it appears there is no link to a bug in the changeset and even no review for this patch. We should really be carefully with that.

http://github.com/mozautomation/mozmill/commit/df8b8361b737a98e9a00b463fac0d78030bad536

The specific case here are the following lines where we go back to call "Runner.get_binary" instead of "self.find_binary()":

http://github.com/mozautomation/mozmill/commit/df8b8361b737a98e9a00b463fac0d78030bad536#L8L56

There are also a couple of other instances in this patch which needs another clean-up.

Jeff or Clint, please check this patch closely so we can revert all the accidental changes.

Comment 1

[Jeff Hammel]

I'm not exactly sure what is actionable in this patch.  Runner.get_binary is intended because it is a class method.  Specifically, we have somewhat of a conundrum:

- the runner needs a profile
- the profile needs a binary to create it
- the runner provides the functionality to find the binary

Luckily, the Runner.get_binary method does not depend on instance variables

Or, maybe I completely misunderstand the point of this bug?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, checking the patch and the current state of the files, I also can't find a problem. I have talked with Mark right before I filed this bug, and he mentioned to me that he had some problems.

Mark, could you please tell us, which problems you had?

Comment 3

[cmtalbert]

no action in 3 months, verified that thunderbird is running fine on 1.5.2 and we have another bug open to address thundfebird incompatibilities with 2.0, so closing this as incomplete since it's an unnecessary bug and contains nothing actionable.