616932 - [Quick Filter bar] Missing tag icon

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[[:Aureliano Buendía]]

Attachment: screenshot

It seems that the bar has a place for tag icon but the icon isn't there.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch

I overseen this reference to a deleted file in Bug 545557. This patch uses the new icon. Instead of an other -moz-image-region, new icon set has only one state, I'm using opacity for disabled state.

I set the same people for review, because they know the previous patches.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: screenshot showing tag icon in enabled and disabled state

Screenshot to show how the tag icon looks with the other icons. Also showing tag icon in disabled state.

Comment 3

[Andreas Nilsson (:andreasn)]

This looks good. We should probably make the other icons monochrome as well, but I'll spin that off as a separate patch.

Comment 4

[Andreas Nilsson (:andreasn)]

Before I give a ui-r+, how do I trigger the disabled state?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to comment #4)
> Before I give a ui-r+, how do I trigger the disabled state?

I don't know how to trigger the disabled state in normal work. I have never seen it disabled.

I forced it with DOMi by setting the DOM Node to disabled=true.

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 495548 [details] [diff] [review]
Patch

It don't seem like the other icons use a disabled state in the css, but this is not a code review, so ui-r+ :)

Comment 7

[Andreas Nilsson (:andreasn)]

(In reply to comment #6)
> Comment on attachment 495548 [details] [diff] [review]
> Patch
> 
> It don't seem like the other icons use a disabled state in the css, but this is
> not a code review, so ui-r+ :)

Err...sorry, it seems like it did before too. Forget what I said. :)

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 495548 [details] [diff] [review]
Patch

Well, I've looked and I've looked and I've looked for something to complain about on this bug, but I just can't find anything.  ;)

r=me.

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/870564ed3d78

Comment 10

[tymerkaev]

Comment on attachment 495548 [details] [diff] [review]
Patch

> #qfb-tags[disabled] {
>-  -moz-image-region: rect(48px, 384px, 72px, 360px) !important;
>+  opacity: .4;
> }

Looks like you want to set opacity for .toolbarbutton-icon only instead of whole button...

Comment 11

[Andreas Nilsson (:andreasn)]

Azat: can you file that as a new bug and attach a patch to fix that?

Comment 12

[Richard Marti (:Paenglab)]

I overseen Azats comment. Filed Bug 626735.