Closed Bug 616967 Opened 14 years ago Closed 13 years ago

Hovering on "Move to Group" on a new profile brings up in the current tab group the tab containing the welcome message.

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: andreea.pod, Assigned: ttaubert)

References

Details

Attachments

(1 file, 7 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101205 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101205 Firefox/4.0b8pre

On a fresh profile at first run, the welcome page from the other tab group appears next to the start pages on current group when you move mouse over the "Move to group" button (not necessary click it).

Reproducible: Always

Steps to Reproduce:
1.Create a new profile
2.Right click on any of the start tabs and mouse over the "Move to Group"
3.Click on the "Group your tabs" button at the end of the toolbar.
Actual Results:  
The welcome page from the second tab appears next to the two existing tabs.

Expected Results:  
When mouse over the "Move to Group" button nothing should happen.

In the screen shot you can see how the tabs appear after entering group tabs.
Attached image screenshot (obsolete) —
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: General → TabCandy
OS: Windows 7 → All
QA Contact: general → tabcandy
Hardware: x86 → All
Target Milestone: --- → Future
Version: unspecified → Trunk
Assignee: nobody → tim.taubert
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #500712 - Flags: review?(ian)
Comment on attachment 500712 [details] [diff] [review]
patch v1

Looks great!
Attachment #500712 - Flags: review?(ian) → review+
Attachment #500712 - Flags: approval2.0?
Attachment #500712 - Flags: approval2.0?
Attached patch patch v2 (cleaned up test) (obsolete) — Splinter Review
Attachment #495485 - Attachment is obsolete: true
Attachment #500712 - Attachment is obsolete: true
Attachment #501646 - Flags: approval2.0?
Comment on attachment 501646 [details] [diff] [review]
patch v2 (cleaned up test)

>+  let prefsBranch = Cc['@mozilla.org/preferences-service;1'].
>+                    getService(Ci.nsIPrefService).
>+                    getBranch('browser.panorama.').
>+                    setBoolPref('experienced_first_run', false);

The prefsBranch variable seems bogus. Also, use Services.prefs (as per bug 622514).
Pushed to try today. Passed.
Attachment #501646 - Attachment is obsolete: true
Attachment #501734 - Flags: approval2.0?
Attachment #501646 - Flags: approval2.0?
Depends on: 610242
Attachment #501734 - Attachment is obsolete: true
Attachment #501788 - Flags: approval2.0?
Attachment #501734 - Flags: approval2.0?
v4 + v2.6 from bug 610242 pushed to try today. Passed.
Comment on attachment 501788 [details] [diff] [review]
patch v4 (test prepared for bug 610242)

a=beltzner
Attachment #501788 - Flags: approval2.0? → approval2.0+
Attached patch patch for checkin (obsolete) — Splinter Review
Passed try.
Attachment #501788 - Attachment is obsolete: true
Attached patch patch for checkin (unrotted) (obsolete) — Splinter Review
Attachment #503372 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
Attachment #503693 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/bf5285a9c2d5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with beta11
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: