updater parameters in update_verify should be changed according to the new syntax

RESOLVED FIXED

Status

Release Engineering
General
P1
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

8 years ago
bug 600777 changed command line parameters of updater(.exe) and added a mandatory apply-to-dir parameter. Full syntax is:

Usage: updater update-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]

At the moment we call updater as
../../update/updater ../../update 0

It tries to chdir to "0" and fails.
(Assignee)

Comment 1

8 years ago
Created attachment 495705 [details] [diff] [review]
verify.sh: add --new-updater parameter
Attachment #495705 - Flags: review?(nrthomas)
(Assignee)

Comment 2

8 years ago
Created attachment 495706 [details] [diff] [review]
update UpdateVerifyFactory
Attachment #495706 - Flags: review?(nrthomas)
(Assignee)

Comment 3

8 years ago
Created attachment 495707 [details] [diff] [review]
configs
Attachment #495707 - Flags: review?(nrthomas)
(Assignee)

Comment 4

8 years ago
Testing the patches in staging. So far verify.sh runs good.
I think I would have set it up as use_old_updater so that you can set the global 'use_new_updater': True, with False on 1.9.1 and 1.9.2, and we don't have to pass --new-updater for future releases. Do we have time to do that ?
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> I think I would have set it up as use_old_updater so that you can set the
> global 'use_new_updater': True, with False on 1.9.1 and 1.9.2, and we don't
> have to pass --new-updater for future releases. Do we have time to do that ?

Sure. I'll update the patches today.
(Assignee)

Comment 7

8 years ago
Created attachment 495808 [details] [diff] [review]
verify.sh: add --old-updater parameter
Attachment #495705 - Attachment is obsolete: true
Attachment #495808 - Flags: review?(nrthomas)
Attachment #495705 - Flags: review?(nrthomas)
(Assignee)

Comment 8

8 years ago
Created attachment 495809 [details] [diff] [review]
update UpdateVerifyFactory
Attachment #495706 - Attachment is obsolete: true
Attachment #495809 - Flags: review?(nrthomas)
Attachment #495706 - Flags: review?(nrthomas)
(Assignee)

Comment 9

8 years ago
Created attachment 495810 [details] [diff] [review]
configs
Attachment #495707 - Attachment is obsolete: true
Attachment #495810 - Flags: review?(nrthomas)
Attachment #495707 - Flags: review?(nrthomas)
Attachment #495808 - Flags: review?(nrthomas) → review+
Attachment #495809 - Flags: review?(nrthomas) → review+
Comment on attachment 495810 [details] [diff] [review]
configs

>diff --git a/mozilla/config.py b/mozilla/config.py
>+    # Bug 617188
>+    'use_old_updater': False,

Nit: The comment isn't necessary. 

Please let the Thunderbird and SeaMonkey guys know about this change in case they're using the 0.8.0 automation and/or it will also be landing on the 0.7 branch.
Attachment #495810 - Flags: review?(nrthomas) → review+
(Assignee)

Comment 11

8 years ago
Comment on attachment 495808 [details] [diff] [review]
verify.sh: add --old-updater parameter

http://hg.mozilla.org/build/tools/rev/89131c300c1c
Attachment #495808 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 627271
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.