617188 - updater parameters in update_verify should be changed according to the new syntax

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Rail Aliiev [:rail]]

bug 600777 changed command line parameters of updater(.exe) and added a mandatory apply-to-dir parameter. Full syntax is:

Usage: updater update-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]

At the moment we call updater as
../../update/updater ../../update 0

It tries to chdir to "0" and fails.

Comment 1

[Rail Aliiev [:rail]]

Attachment: verify.sh: add --new-updater parameter

Comment 2

[Rail Aliiev [:rail]]

Attachment: update UpdateVerifyFactory

Comment 3

[Rail Aliiev [:rail]]

Attachment: configs

Comment 4

[Rail Aliiev [:rail]]

Testing the patches in staging. So far verify.sh runs good.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

I think I would have set it up as use_old_updater so that you can set the global 'use_new_updater': True, with False on 1.9.1 and 1.9.2, and we don't have to pass --new-updater for future releases. Do we have time to do that ?

Comment 6

[Rail Aliiev [:rail]]

(In reply to comment #5)
> I think I would have set it up as use_old_updater so that you can set the
> global 'use_new_updater': True, with False on 1.9.1 and 1.9.2, and we don't
> have to pass --new-updater for future releases. Do we have time to do that ?

Sure. I'll update the patches today.

Comment 7

[Rail Aliiev [:rail]]

Attachment: verify.sh: add --old-updater parameter

Comment 8

[Rail Aliiev [:rail]]

Attachment: update UpdateVerifyFactory

Comment 9

[Rail Aliiev [:rail]]

Attachment: configs

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 495810 [details] [diff] [review]
configs

>diff --git a/mozilla/config.py b/mozilla/config.py
>+    # Bug 617188
>+    'use_old_updater': False,

Nit: The comment isn't necessary. 

Please let the Thunderbird and SeaMonkey guys know about this change in case they're using the 0.8.0 automation and/or it will also be landing on the 0.7 branch.

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 495808 [details] [diff] [review]
verify.sh: add --old-updater parameter

http://hg.mozilla.org/build/tools/rev/89131c300c1c

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 495809 [details] [diff] [review]
update UpdateVerifyFactory

http://hg.mozilla.org/build/buildbotcustom/rev/4febe8d47e48

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 495810 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/8ebfd26e4a5e