617359 - password notification bar hidden underneath urlbar on slow connections

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: bug screenshot

Build Id:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101207 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101207 Namoroka/4.0b8pre Fennec/4.0b3pre


Steps to Reproduce:
1. Go to www.tumblr.com/login
2. Enter in sign in info for an account @ tumblr, but that is not in the password manager
3. Sign In

Actual Results:
The password notification bar is hidden underneath the url bar (check out the bug screenshot)

Expected Results:
The password notification bar should not be hidden on first view.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Notify

Pretty simple solution. Scrolls the whole pageScrollbox into view if the toolbar is locked and an alert is shown.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 504028 [details] [diff] [review]
Notify


>     window.addEventListener("resize", resizeHandler, false);
>+    window.addEventListener("AlertActive", this._alertShown.bind(this), 0);

last param should be | false |, not | 0 |

>+  _alertShown: function _alertShown() {
>+    if (BrowserUI.isToolbarLocked())
>+      Browser.pageScrollboxScroller.scrollTo(0, 0);
>+  },

This might potentially change a previous scroll position, or a URL # fragment anchor scroll position. But I am willing to give it a higher precedent.

Add a comment so we remember that we are scrolling the page so the notification is in full view and not obscured by the floating toolbar.

Comment 4

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/mozilla-central/rev/bac4967513e6

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Screenshot

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110506 Firefox/6.0a1 Fennec/6.0a1
Device: Thunderbolt
OS: Android 2.2

Once the page loads, it does show the notification without being obsecured by the URL bar.  When the page is loading, the notification will still be obsecured by the URL bar.  See attachment.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This also occurs on droid 2:

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110506 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2

Comment 7

[Cristian Nicolae (:xti)]

Attachment: Screenshot 2

Is this result related to this bug?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #7)
> Created attachment 532132 [details]
> Screenshot 2
> 
> Is this result related to this bug?

yes

Comment 9

[Cristian Nicolae (:xti)]

TC https://litmus.mozilla.org/show_test.cgi?id=15036 fails due to this bug.

Comment 10

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110529 Firefox/7.0a1 Fennec/7.0a1 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110529 Firefox/6.0a2 Fennec/6.0a2 

Build Id: Mozilla/5.0 (Maemo; Linux armv7l; rv:7.0a1) Gecko/20110529
Firefox/7.0a1 Fennec/7.0a1

Devices: HTC Desire Z (Android 2.2), Nokia N900 (Maemo GTK)