617491 - [traceback] TypeError: unsupported operand type(s) for *=: 'NoneType' and 'int'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://services.addons.mozilla.org//pt-PT/firefox/api/1.5/search/guid:[e-mail],[e-mail],%7B62760FD6-B943-48C9-AB09-F99C6FE96088%7D,%7B872b5b88-9db5-4310-bdd0-ac189557e5f5%7D,%7B9AA46F4F-4DC7-4c06-97AF-5035170634FE%7D,%7BACAA314B-EEBA-48e4-AD47-84E31C44796C%7D,%7BE9A1DEE0-C623-4439-8932-001E7D17607D%7D,[e-mail],[e-mail],%7BDB9127A2-3381-41ec-82B3-1B6ED4C6F29A%7D,avg@igeared,[e-mail],%7B3f963a5b-e555-4543-90e2-c3908898db71%7D,[e-mail],[e-mail],%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D,[e-mail],%7B81514210-E22A-4e69-93D5-E1EFD45B4620%7D,%7B371019f6-f889-4ba8-9dfe-4476c920e6ad%7D,%7Bb2460731-3cd0-4755-ab04-8913de5a087c%7D,%7B4ee011f9-0a37-4648-86c3-8c625804ef24%7D,%7Bfc6011de-004a-4811-8323-a0bdb9638bf4%7D,%7B93631265-7210-4662-80d0-7c1f1926db2f%7D,%7B25970f6d-b4f1-4ea5-91c6-ca32b9c8e5d7%7D,%7B93c5eb7a-585a-44dd-8acf-37558f2f8235%7D,%7Ba1165d02-4748-4d4f-80e2-d10fc49e33cd%7D,%7B5fbf7af2-5c01-4da3-aa7e-e3f68a677636%7D,%7B6f0bf8fb-1aa1-4837-8116-4d124a%20%200760f6%7D,%7B5bab9bd0-888f-47d6-8e11-42672ac06882%7D,%7Babd73548-de03-4c61-b5f5-bfbbee4addc4%7D,%7B875c0ad3-da81-451b-ae69-7e95cfbf4100%7D,%7Baf764d22-39ef-48f5-8e57-7357679b4969%7D,%7B896887de-38dc-46a2-858c-260571eb3455%7D,%7Bde5b0132-729f-43d4-9776-8997b94da8dc%7D yields:

Traceback (most recent call last):

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/urls.py", line 14, in <lambda>
    inner = lambda *args, **kw: cls()(*args, **kw)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 157, in __call__
    return self.process_request(*args, **kwargs)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 248, in process_request
    {'results': results, 'total': sc.total_found})

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 176, in render
    mimetype=self.mimetype)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/views.py", line 59, in render_xml
    rendered = template.render(**context)

  File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 705, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/amo_python/www/services.prod/zamboni/apps/api/templates/api/search.xml", line 4, in top-level template code
    {% include 'api/includes/addon.xml' -%}

  File "/data/amo_python/www/services.prod/zamboni/apps/api/templates/api/includes/addon.xml", line 1, in top-level template code
    {% cache addon, extra=[api_version] %}

  File "/data/amo_python/www/services.prod/zamboni/apps/amo/ext.py", line 22, in _cache_support
    return sup(key, obj, timeout, extra, caller)

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django-cache-machine/caching/ext.py", line 74, in _cache_support
    return caching.base.cached_with(obj, caller, key, timeout)

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 282, in cached_with
    return cached(f, key, timeout)

  File "/data/amo_python/www/services.prod/zamboni/vendor/src/django-cache-machine/caching/base.py", line 262, in cached
    val = function()

  File "/data/amo_python/www/services.prod/zamboni/apps/api/templates/api/includes/addon.xml", line 94, in template
    {{ addon.suggested_amount|currencyfmt('USD') }}

  File "/data/amo_python/www/services.prod/zamboni/apps/amo/helpers.py", line 146, in currencyfmt
    return _get_format().currency(num, currency)

  File "/data/amo_python/www/services.prod/zamboni/vendor/lib/python/babel/support.py", line 121, in currency
    return format_currency(number, currency, locale=self.locale)

  File "/data/amo_python/www/services.prod/zamboni/vendor/lib/python/babel/numbers.py", line 201, in format_currency
    return pattern.apply(number, locale, currency=currency)

  File "/data/amo_python/www/services.prod/zamboni/vendor/lib/python/babel/numbers.py", line 476, in apply
    value *= self.scale

TypeError: unsupported operand type(s) for *=: 'NoneType' and 'int'

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Quick-commit was https://github.com/jbalogh/zamboni/commit/9b15a54f0cd6c1eb112e9e5041bc2627e51d01a6; not sure if there's more to do here later.

Comment 2

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/afeb98c

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on preview/allizom.