Closed Bug 617790 Opened 14 years ago Closed 14 years ago

[profile] mozprofile should have a clone option

Categories

(Testing Graveyard :: Mozmill, defect)

Product:
Testing Graveyard
Component:
Mozmill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: k0scist, Assigned: k0scist)

References

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(1 file)

moves managing of profile state to the profile
2.80 KB, patch
harth
: review+
Details | Diff | Splinter Review
Currently, MozMill restart bends over backwards to reconstruct a profile: https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L422 Instead, this functionality should be introduced as a .clone method (maybe @classmethod, if that makes sense) into MozProfile. This lets the data and duplication lives where it makes sense.
Whiteboard: [mozmill-2.0?]
Summary: mozprofile should have a clone option → [profile] mozprofile should have a clone option
Assignee: nobody → jhammel
Blocks: 626971
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
Blocks: 521396
Attachment #508952 - Flags: review?(fayearthur+bugs)
The patch actually does reset instead of clone because that is in fact the functionality that is needed. A clone would be easy to do if additionally required.
Comment on attachment 508952 [details] [diff] [review] moves managing of profile state to the profile nice code improvement, r=me.
Attachment #508952 - Flags: review?(fayearthur+bugs) → review+
pushed to master https://github.com/mozautomation/mozmill/commit/4a0f83edea97e2ca73b0f8a2ef33ffc05fe4e4e1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Jeff, why have you switched the docstyle? As you told me everything should be in the same line for short descriptions. That's also what we have in this file in other areas.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: