626971 - Restart tests fail in Mozmill 2 due to: create_new_profile() takes exactly 1 argument (2 given)

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

After a restart test has been executed we fail:

Traceback (most recent call last):
  File "/Volumes/data/testing/envs/mozmill-2/bin/mozmill", line 8, in <module>
    load_entry_point('mozmill==2.0a', 'console_scripts', 'mozmill')()
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 637, in cli
    CLI(args).run()
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 612, in run
    self.run_tests(MozMillRestart, restart_tests, runner, results)
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 579, in run_tests
    mozmill.run(tests)
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 263, in run
    self.run_tests(tests)
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 472, in run_tests
    self.run_dir(d, sleeptime)
  File "/Volumes/data/build/tools/mozmill-2.0/mozmill/mozmill/__init__.py", line 445, in run_dir
    profile.profile = profile.create_new_profile(self.runner.binary)                
TypeError: create_new_profile() takes exactly 1 argument (2 given)


I really really would like to see a test here which successfully runs restart tests. We already had too many fallouts from that change.

Comment 1

[Jeff Hammel]

At the least, the profile should have a clone method.  The above is a one line fix (no longer pass the binary, it was never used), but the surrounding code is somewhat awful.  If we're going to clone the profile, since the profile is the only portion of code that knows what its supposed to contain, it should be responsible for cloning.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=627160

Comment 2

[Jeff Hammel]

this was broken with the landing of Bug 609633

Comment 3

[Jeff Hammel]

fix with bug 617790

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works now again. Thanks Jeff.