617993 - jetpack.views can use major refactoring

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Description

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

After coverage is complete, we can go in and rename views to be a bit more descriptive.  There's a lot of minor things that could enhance code readability:

* Renaming methods so they don't all start with package_ - we're in the jetpack view we know we're dealing with jetpack packages.
* the template choosing could be a bit cleaner, it'd be nice if each view had it's unique template and it wasn't parameterized, because it makes it hard to test.  At the very least what the template suffix stuff can be pulled into a new method that woudl have its own tests.
* we shoudl override render_to_response so it always gives us the request context, it's silly to spell it out each time.
* view methods should take the parameter 'request' not 'r' this is django convention.

I think with some refactoring we can get the file size down, and make this app really easy to dive into for new developers.

Comment 1

[Piotr Zalewa [:zalun]]

refactoring is always good.

Comment 2

[Andy McKay]

and lets get a render to json shortcut too...

Comment 3

[Daniel Buchner [:dbuc]]

What is the status on this Piotr?

Comment 4

[Piotr Zalewa [:zalun]]

not touched yet

Comment 5

[Piotr Zalewa [:zalun]]

in review https://github.com/zalun/FlightDeck/commit/03266a985fc94c6f30f6a30222d72d9c07b9b1b5