618311 - Inspect Network Request window persists on close of Web Console - PB data leak

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101210 Firefox/4.0b8pre

Currently, the inspect network request window will persist on close of the web console -- which is triggered automatically by an enter/exit of PB mode. Thus some may consider a data leak[1], such as q=christmas%20gifts

[1] http://clients1.google.ca/complete/search?&q=christmas%20gift

As far as I think, keeping the window open is for debugging purposes, as well it is a pretty bizarre edge case. Ehsan, would you consider this a data leak for PB mode?

1. Enter PB mode
2. Go to google.com and open the web console
3. Enter a search term, "Christmas gifts"
4. Click on a query request. The inspect network request window should open.
5. Exit PB mode

ER: Inspect network request window should close

Comment 1

[(no longer active)]

(In reply to comment #0)
> As far as I think, keeping the window open is for debugging purposes, as well
> it is a pretty bizarre edge case. Ehsan, would you consider this a data leak
> for PB mode?

Yes, for sure!

We have similar code for page info windows <http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/src/nsPrivateBrowsingService.js#393>.  David, do you know what windowtype I should use to catch the inspector panels?

Comment 2

[Rob Campbell [:rc] (:robcee)]

adding this as a dependent to bug 602199

Comment 3

[Kevin Dangoor]

Also worth noting is that i bet the object inspector does the same thing.

Comment 4

[Johnathan Nightingale [:johnath]]

Notes from the Grand Retriage: I'd like to see it fixed, but it doesn't block.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Proposed fix. This makes panels opened by a specific Web Console to close automatically when the Web Console is closed. This does not only fix issues with Private Browsing, but also with stale panels staying open after their Web Console (or tab) is closed.

I know this is scheduled for a .x release, but I think it would be a nice piece of Web Console polish to have it for Fx4, given sufficient feedback/review resources. Thanks!

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 510347 [details] [diff] [review]
proposed fix

this seems reasonable enough.

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 510347 [details] [diff] [review]
proposed fix

Thanks for the feedback+! Asking for review.

Comment 8

[(no longer active)]

Can you please extend the test to cover private browsing mode switch as well?

Comment 9

[Mihai Sucan [:msucan]]

Attachment: updated patch

Added a test for private browsing as well, as requested by Ehsan.

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 510591 [details] [diff] [review]
updated patch

>+++ b/toolkit/components/console/hudservice/HUDService.jsm
>+++ b/toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_618311_close_panels.js
>@@ -0,0 +1,93 @@
>+/*
>+ * Any copyright is dedicated to the Public Domain.
>+ * http://creativecommons.org/publicdomain/zero/1.0/
>+ *
>+ * Contributor(s):
>+ *   Mihai Èucan <[e-mail]>
>+ */
global-nit: should just be https://www.mozilla.org/MPL/boilerplate-1.1/pd-c

r=sdwilsh

Comment 11

[Mihai Sucan [:msucan]]

Thanks for the review+ Shawn!

Comment 12

[Mihai Sucan [:msucan]]

Attachment: [in-devtools] rebased patch

Ready to land (mozilla-central, default branch).

Comment 13

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 521232 [details] [diff] [review]
[in-devtools] rebased patch

checked into devtools:

http://hg.mozilla.org/projects/devtools/rev/79f09037701d

Comment 14

[Rob Campbell [:rc] (:robcee)]

http://hg.mozilla.org/mozilla-central/rev/79f09037701d

Comment 15

[Simona Badau, Desktop QA]

Verified on:
Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110403 Firefox/4.2a1pre