618316 - Downloading Fennec update doesnt resume when switching connectivity

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[Tony Chung [:tchung]]

I just tried updating my fennec from 12/09 build to the 12/10 build, via connected to wifi.  While downloading, I switched out of wifi to 3G.   The fennec download notification went away and did not resume the update.  Can we get update to resume while switching networks?

Dependency of bug 609366?

Repro:
1) install fennec 12/09 nightly.  Log into wifi connection
2) find the nightly update, and download it
3) while the download is in progress, hop over to 3G connection
4) Verify the fennec notification dissapears and the download cancels

Expected:
- download resumes when switching networks

ActuaL:
- download cancels

Comment 3

[Alex Pakhotin (:alexp)]

Robert, do you have any thoughts, what would be required to fix this bug (or rather implement this feature) in the update service? I guess we need some kind of a timeout with retry before marking the download as failed and canceling it.

Comment 4

[Catalin Suciu [:csuciu]]

Bug is reproducible when updating from 08/07 build to the 08/08 build on HTC Desire (Android 2.2)

Build download is not resumed when switching networks or when a network connection is lost then re-connected.

Comment 5

[Robert Strong (they/them - no direct email)]

Alex, can you check what nsIIncrementalDownload is returning when this occurs?

Comment 6

[Alex Pakhotin (:alexp)]

Here's what I get in the log:
*** AUS:SVC Downloader:onStopRequest - original URI spec: http://people.mozilla.com/~alexp/android/update/fennec.apk, final URI spec: http://people.mozilla.com/~alexp/android/update/fennec.apk, status: 2152398862
*** AUS:SVC Downloader:onStopRequest - non-verification failure
*** AUS:SVC getStatusTextFromCode - transfer error: Connection timed out, code: 2152398862
*** AUS:SVC Downloader:onStopRequest - setting state to: download-failed
*** AUS:SVC Downloader:onStopRequest - all update patch downloads failed

Do you need more details?

Comment 7

[Robert Strong (they/them - no direct email)]

I think NS_ERROR_NET_TIMEOUT will need to be special cased and have a fallback so if it happens to many times without successfully downloading the user is informed of the error so they can download a new build.

Comment 8

[Catalin Suciu [:csuciu]]

I've checked this issue and noticed that, when switching networks, on build:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101123
Firefox/4.0b8pre Fennec/4.0b3pre
Download is suspended but it's not resumed.
http://hg.mozilla.org/mozilla-central/rev/4b9ba5049e66
 
and on build:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101124
Firefox/4.0b8pre Fennec/4.0b3pre
Download cancels
http://hg.mozilla.org/mozilla-central/rev/7f5cd850578e

Possible range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4b9ba5049e66&tochange=7f5cd850578e

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Would it be possible to have the update download to download to the download folder and also in the download notifications?

Comment 10

[Robert Strong (they/them - no direct email)]

Fennec doesn't use the app update code anymore