618335 - Sync does not accept old style sync key

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have created an account with 3.6.12/1.5.1, which looks like this:

username: [e-mail]
password: password
sync key: dxdsg-pdnbq-ifply-luocn

I then quit Firefox and run Minefield trunk (2010-12-10) and create a new empty profile. I setup sync and enter all the above.

Sync does not accept the sync key. The Continue button is blue but clicking it does not do anything.

When I remove the hyphens it does its "verifying' thing without errors. When i then hit Continue it proceeds without errors.

However, sync fails. I do not get my bookmarks restored and I see a 'Sync Failed' error at the bottom of the screen.

Reproducable, tried 3 times.

Will attach logs as soon as I have them.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Log of sync setup

Comment 2

[Philipp von Weitershausen [:philikon]]

Yes, hrm, we no longer accept the old 20 char dashed Sync Key as input. You need to type it in without the dashes. We should probably fix that... Grrr...

The log reveals you're running into bug 618068. Unrelated to the UI.

Comment 3

[Mike Connor [:mconnor]]

I think we should fix this for b9, and relnote for b8.

Comment 5

[Tony Chung [:tchung]]

(In reply to comment #3)
> I think we should fix this for b9, and relnote for b8.

Can we retriage this fix for b8?  (re-nom'ing blocker)  Users with the 20-char-dash keys will be copying/pasting the key they were asked to save beforehand, which includes the dashes.  They're not going to see your relnote unless you have it on the setup UI to strip it out.   It was causing me headaches all afternoon (see bug 618068), and i'm certain you'll hear from others as well.  If the fix is not hard, i highly suggest we get this back in.

Comment 6

[Mike Connor [:mconnor]]

Users who are setting up new devices will be directed to the J-PAKE flow, not to the manual setup flow, as a primary user path.  And that's only if they're setting up a new device, as upgrades should be seamless.

We're in risk mitigation mode right now, and I really think this isn't an absolute requirement for b8.

Comment 7

[Richard Newman [:rnewman]]

Working on this.

Comment 8

[Richard Newman [:rnewman]]

I just:

* Created a new account with 3.6.13 + 1.5.1
* Launched 2010-12-14 nightly and pasted in my passphrase: "zpleg-njmog-mkjjf-linaz"
* Sync proceeded correctly
* The old client shows an error about needing to upgrade Sync.

Stefan, can you still repro? My suspicion is that this is the same as Bug 618411.

Comment 9

[Richard Newman [:rnewman]]

Resolving. Stefan, please reopen if this still doesn't work for you with current builds.

Comment 10

[Philipp von Weitershausen [:philikon]]

Richard, I think you perhaps misunderstood the bug. It's about not being able to enter the dashed version of the old-style 20 character Sync Key, e.g. dxdsg-pdnbq-ifply-luocn. We just treat everything that's not the dashed representation of our 26 character new-style Sync Key as an opaque passphrase and feed it into the PBKDF2 upgrade step. This means dxdsg-pdnbq-ifply-luocn won't be the same as dxdsgpdnbqifplyluocn, but it should be.

The fix here is to make Utils.normalizePassphrase() recognize dashed old-style Sync Keys and remove the dashes.

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to comment #8)
> * Created a new account with 3.6.13 + 1.5.1
> * Launched 2010-12-14 nightly and pasted in my passphrase:
> "zpleg-njmog-mkjjf-linaz"
> * Sync proceeded correctly
> * The old client shows an error about needing to upgrade Sync.

This is not the right way to repro this. What you did meant that the Minefield profile saw a v3 account, so you could have entered *any* Sync Key and it would've worked because it just simply wipes the server and uploads the data. If you would've upgraded the 3.6.x profile to Sync 1.6, you would've gotten a Wrong Sync Key error.

What you need to do to repro is:

1. Create a new account with 3.6.13 + 1.5.1 or 4.0b7, remember old-style Sync Key.
2. Migrate that profile to Sync 1.6 or a nightly/4.0b8 so that the account is at v5 and the new style Sync Key was generated from the old style one using PBKDF2
3. Take a *second* nightly/4.0b8 profile and now try to connect to the account by pasting in dashed version of old-style Sync Key.

Comment 12

[Richard Newman [:rnewman]]

Ah, good call. Thanks Philipp. Will fix on Monday.

Comment 13

[Richard Newman [:rnewman]]

Attachment: normalizePassphrase applies to 5x4 keys, v1

This should do the trick. Verified using the steps from your last comment, Philipp. Review, please?

Comment 14

[Philipp von Weitershausen [:philikon]]

Comment on attachment 498686 [details] [diff] [review]
normalizePassphrase applies to 5x4 keys, v1

Lovely. Please commit to both the default and 1.6.x branch in fx-sync.

Comment 15

[Richard Newman [:rnewman]]

Pushed:

1.6.x: http://hg.mozilla.org/services/fx-sync/rev/57ec1b19e232
default: http://hg.mozilla.org/services/fx-sync/rev/00c94d9b2633

Comment 16

[Tracy Walker [:tracy]]

verified with 1.6.1 and beta8 builds

Comment 17

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)

Comment 18

[Nochum Sossonko [:Natch]]

Christian, Any reason you removed the Cc's?

Comment 19

[Richard Newman [:rnewman]]

(In reply to comment #18)
> Christian, Any reason you removed the Cc's?

Bug in his script. Nothing to worry about; he's putting them back.

Comment 20

[Daniel C]

I had an old sync account which was setup with a freeform-style key. Minefield then changed it without any notification to a dashed 26 character key and view quota said 0 bytes for everything. Other clients then wouldn't sync due to an invalid key. In those clients, view key doesn't let you change the key. You need to click "Connect" and wait for it to ask you to update the key.

Is any of that supposed to happen? I assumed the old Weave style key would still be supported where it already existed.