618411 - No action if there is a non-alphabetical character in the sync key

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ayan Shah[:ashah]]

Sync on Minefield (20101210)

Open Sync. Click Setup sync and then click "I dont have the device with me".
This will take you to the login screen. There, type in your correct account name and password. Then in the sync key, type in a wrong key, BUT, put a non alphabetical character in the sync key, like a space, or a $, or a # etc. 
For eg. "ssdf sdfds" or "ewr#sdfwe$"

Expected result:
It should give an error for wrong sync key

Actual result:
Nothing happens. I can click on the continue button but nothing happens on the screen.

Note: If you remove non-alphabetical characters from the sync key(for eg: type "sdfsdf"), it will check and give you the error for wrong sync key. But this does not happen if non-alphabetical characters are present

Comment 1

[Philipp von Weitershausen [:philikon]]

I can confirm this. Working on a fix.

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Do not hit generateEntry when we have an old style Sync Key.

Comment 4

[Philipp von Weitershausen [:philikon]]

Landed on fx-sync:
https://hg.mozilla.org/services/fx-sync/rev/1418982c9333

Merged to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/43a54dd56ccd

Comment 5

[Tracy Walker [:tracy]]

still seeing this on nightly trunk builds from 20101214
using a hyphenated key.

fixing this would make bug 618336 tolerable.

Comment 7

[Hmmwhatsthisdo]

Using Portable FF 3.6 on Windows, I have gotten errors with the latest version of Sync when mis-spelling my Sync key (a phrase with many spaces and periods).

Comment 8

[Mike Connor [:mconnor]]

Please file a separate bug, this is on the Fx4 in-product UI.

Comment 9

[Tracy Walker [:tracy]]

Verified fixed with the first build of Beta8.  CnP of a hyphenated key from 1.5.1 was accepted when adding beta8 to the existing account.