Closed Bug 618337 Opened 9 years ago Closed 9 years ago

regress-336409-1.js fails with wrong error message

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: paul.biggar, Unassigned)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file)

Running this solo, it takes a bit over 1GB of RAM then dies with the wrong error when my system refuses to give it more (error below). The manifest shows it's expected to fail in xulRuntime, so I'm guessing the right fix here is to make it skip in general?

Manifest:
  skip-if(!xulRuntime.shell) script regress-336409-1.js # no results reported.


Test log:
 $ python ./tests/jstests.py --args="-j -m" -s -o build_baseline_DBG.OBJ/js regress-336409-1.js
warning: invalid manifest line element "silentfail"
warning: invalid manifest line element "silentfail"
warning: invalid manifest line element "silentfail"
/Users/pbiggar/work/mozilla/bug581179/js/src/build_baseline_DBG.OBJ/js -j -m -f shell.js -f js1_5/shell.js -f js1_5/extensions/shell.js -f ./js1_5/extensions/regress-336409-1.js
    rc = 0, run time = 64.901349
BUGNUMBER: 336409
STATUS: Integer overflow in js_obj_toSource
--- NOTE: IN THIS TESTCASE, WE EXPECT EXIT CODE 0 ---
--- NOTE: IN THIS TESTCASE, WE EXPECT EXIT CODE 5 ---
STATUS: Creating 64MB string
STATUS: Done. length = 67108864
STATUS: Creating object
STATUS: object.toSource()
InternalError: allocation size overflow
 FAILED! Integer overflow in js_obj_toSource : Expected value 'InternalError: script stack space quota is exhausted', Actual value 'InternalError: allocation size overflow' 
REGRESSIONS
    js1_5/extensions/regress-336409-1.js
FAIL
Attached patch change errorSplinter Review
Simple fix for the error message.
Attachment #499927 - Flags: review?
Comment on attachment 499927 [details] [diff] [review]
change error

Looks like your requestee didn't get set, but this one's easy so I'm just going to r+ it.
Attachment #499927 - Flags: review? → review+
http://hg.mozilla.org/tracemonkey/rev/f826d4d3bc53
Whiteboard: [fixed-in-tracemonkey]
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.