618374 - new addon bar "close button" is mispositioned, in my existing profile

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Today's nightly added a close button to the addon bar. (bug 616014)

According to the original spec on that bug, it's supposed to be on the left ("the opposite side of where add-on icons start"), but on my profile, it had two issues:
 (1) it's grouped with the other addon icons
 (2) it seems to have moved itself & the other addon icons to the center

See attached screenshot.

In a fresh profile, this works correctly -- so there's some interaction with my specific profile that's going wrong.

Comment 1

[Dão Gottwald [:dao]]

You'll need to restore the default set.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: reduced localstore.rdf file that causes the problem

I localized the problem to being in my localstore.rdf -- specifically, this minimal localstore.rdf that I'm attaching.  If I stick that in a fresh profile and start today's nightly with that profile, it's got the addon bar's close button in the middle.

Comment 3

[Daniel Holbert [:dholbert]]

I confirmed that "Restore Default Set" in the UI "Customize" dialog does indeed fix this.

I'm not sure how my localstore.rdf file ended up with the faulty chunk.  My addon-bar layout was working fine until today.

It may have been an interaction with the "Status-4-Evar" addon, which also sticks content on the left side of the addon bar.  (Also: I disabled that addon while reducing the problem here, and now that I've re-enabled it, it seems not to show up in the Addon bar anymore.  So, probably likely that the addon & close button were stomping on each other somehow.)

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to comment #3)
> It may have been an interaction with the "Status-4-Evar" addon

...though ehsan hit a similar problem in Bug 618326, and he says in IRC that he was not using Status-4-Evar.

Comment 6

[Daniel Holbert [:dholbert]]

Dao / Dietrich: Is there anything we can do to preemptively keep this problem from happening?

I'm worried that when beta 8 is released, we'll have a lot of users upgrading to beta 8 who run into this issue in the same way that ehsan and I did.

Comment 7

[Dietrich Ayala (:dietrich)]

We could write some code specifically to handle migration from b7 to b8 for this change. However, I think the cost is not worth the benefit. This is a side-effect of running betas, that will happen only to a limited number of beta users. We should add this to the release notes however.

Comment 8

[[not reading bugmail]]

This is the bug I am seeing and thinking it will throw off users completely, unless we can force it to the left of statusbar icons.

Comment 10

[Robert Utasi [:hunboy]]

Thank You reordering me. (it was closed so I did not find it as opened bug)

Currently i moved everything from statusbar (addonbar), to left the close-button alone, and did put back everything to add-on bar.
It's almost good.
Close-button at far-left-side, and everything are after that. (At left or right as I want.)

(I couldn't replace the close-button to the far-right.)

Only 1 problem left: the statustext is still reduced and truncated. That statustext might be visible with long url's also if there is enough space for it. And there is. I'm about to email to Status-4-Evar developer, we will se, if it is fixable inside the add-on or not.

Thank You All for the cooperation.