61877 - When asked to Remember Password, Should be Y/N/V hotkey

Status: REOPENED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Brian Z]

Build ID:  200120220

Please excuse me if I've posted to the wrong area.  I wasn't completely sure
with this bug.

When asked wether or not to remember a password for a given site, you should be
able to answer the dialog box by hitting the Y key for Yes, N key for No, and
something like the V Key for Never.  I would really appreciate this so I don't
have to always go to the mouse as I'm loging into sites.  Thanks!  Keep up the
great work!

Comment 1

[Brian Z]

I'd like to help with this if I could.  Do you know which xul file (if any) 
contains the code to this particual dialog box?

Comment 2

[sairuh (rarely reading bugmail)]

cc'ing passwd mgr folks.

Comment 3

[Stephen P. Morse]

Dialog is put up by the call to Wallet_3ButtonConfirm in wallet.cpp.  This in 
turn calls on UniversalDialog in nsCommonDialogs.cpp which in turn puts up the 
commonDialog.xul file.

Comment 4

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 5

[Chris McAfee]

I agree, that dialog is annoying and should have some
kind of easy dismisal mechanism.  nsbeta1, morse.

Comment 6

[Stephen P. Morse]

This is not a password-manager problem but rather a more fundamental 
problem involving all dialogs  That's ben's area.

Comment 7

[Brian Z]

That's a good point.  I haven't noticed any dialogs that allow shortcut keyboard
keys.  I could have missed one though.  I guess I'm a person who likes to keep
my hands at the keyboard as much as possible.  Thanks!

Comment 8

[Paul Chen]

nav triage team:

Not a beta1 stopper, marking nsbeta1-

Comment 9

[Gervase Markham [:gerv]]

You need to be adding the bindings to the keyset in
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/win/platfo
rmDialogOverlay.xul and they'll appear in all OK/Cancel/Never dialogs. Binding 
"Never" might be harder, because this dialog only refers to the buttons 
generically.

Of course, you'll probably need to mess with stuff like string bundles for 
localisation etc. etc.

Enter is already bound to Yes, and Escape to No.

Gerv (lxr browser)

Comment 10

[timeless]

http://msdn.microsoft.com/library/books/winguide/appxB.htm
Avoid assigning access keys to OK and Cancel when the ENTER key and
ESC key, respectively, are assigned to them by default.

please see bug 64457. Where do Yes and No live?

Comment 11

[Brian Z]

Nominating mozilla0.9.  It would be nice if this was cleared up for then.

Comment 12

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 13

[Brian Z]

Nominating mozilla0.9.2 so it gets reviewed sometime.

Comment 14

[Brian Z]

Offloading to mozilla1.0.1

Comment 15

[Judson Valeski]

we wouldn't hold 1.0.1 for this, minusing. it would be nice to have though, if a
patch becomes avail, please re-nominate.

Comment 16

[Akkana Peck]

I'm going to look into this.

Comment 17

[Akkana Peck]

Really, this should be a dup of 134066, since it would use the default values of
nsIPromptService.

*** This bug has been marked as a duplicate of 134066 ***

Comment 18

[sairuh (rarely reading bugmail)]

mass-verification of Duplicates.

mail search string for bugspam: SolarFlaresAreTheCause

Comment 19

[Jesse Ruderman]

Y and N work now that bug 134066 is fixed, but V still doesn't work.

Comment 20

[Akkana Peck]

Removing myself as assignee for editor bugs, since the editor project is (sadly) long gone.