Closed
Bug 134066
Opened 23 years ago
Closed 22 years ago
nsIPromptService does not support accesskey
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
References
(Blocks 2 open bugs)
Details
(Keywords: access, dev-doc-complete)
Attachments
(1 file)
4.86 KB,
patch
|
samir_bugzilla
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
When using nsIPromptService::ConfirmEx() for example, there is no way to ask for buttons that have underlined letters (accesskey's). Thus there is no way to associate Alt+S with _S_ave, for example.
Comment 1•23 years ago
|
||
I'm pretty sure that the cookie accept dialog uses nsIPromptService as well, so marking this as blocking bug 107560
Blocks: 107560
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Comment 3•22 years ago
|
||
Suppose XUL accesskeys could be coded using an entity from a DTD, like &_; right before the letter to be underlined.. For example: Save &_;As To make it legal, there would have to be a DTD entry: <!ENTITY _ ""> Then, wherever it is that we decode entities, we would SetAttribute(accesskey, letter) when we saw thsi entity, in order to implement it. This would make some things easier, make it possible to remove some code, and allow nsIPromptService to support accesskey without adding additional arguments. Is this a good idea?
Comment 4•22 years ago
|
||
why not make it much simpler and use, say, only an underscore like: Save _As
Assignee | ||
Comment 5•22 years ago
|
||
Because presumeably _ is a legal character, that someone might want in their text.
Assignee | ||
Comment 6•22 years ago
|
||
Just spoke with danm about it. nsIPromptService isn't frozen. Perhaps we can do something to it without messing up to many people. If we choose & (as Windows does), then we'll probably need to make \& work if they really do want an &. Dan, would this affect a lot of embeddors?
Updated•22 years ago
|
Assignee | ||
Comment 10•22 years ago
|
||
I told ccarlen I would do it. I know, this is important work -- until another engineer can help out on accessibility/keyboard issues, I can't say when it will get done. Or, ccarlen, maybe you have time for it?
Keywords: nsbeta1
Assignee | ||
Comment 11•22 years ago
|
||
Also fixes bug 133582, so that simple dialogs with "Don't ask me again" checkboxes don't start with initial focus on checkbox, but on first button instead. Seeking r=
Comment 12•22 years ago
|
||
Comment on attachment 101196 [details] [diff] [review] Allows users of nsIPromptService to insert "&" before a char to make it the accesskey (&& escapes if you really want &) r=sgehani
Attachment #101196 -
Flags: review+
Comment 13•22 years ago
|
||
Comment on attachment 101196 [details] [diff] [review] Allows users of nsIPromptService to insert "&" before a char to make it the accesskey (&& escapes if you really want &) sr=hewitt
Attachment #101196 -
Flags: superreview+
Assignee | ||
Comment 15•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 16•22 years ago
|
||
Comment on attachment 101196 [details] [diff] [review] Allows users of nsIPromptService to insert "&" before a char to make it the accesskey (&& escapes if you really want &) >+ var accessKeyIndex; >+ if (aLabel.charAt(0) == '&') { >+ accessKeyIndex = 0; >+ } >+ else { >+ accessKeyIndex = aLabel.search(/[^\&]\&[^\&]/) + 1; >+ if (accessKeyIndex == 0) { >+ accessKeyIndex = -1; // magic value for no accesskey >+ } >+ } Edge case: "&&" becomes "&" with accesskey="&"?
Assignee | ||
Comment 17•22 years ago
|
||
Neil, if you mean that if the string starts with &&, you're right -- I see now that it would make an accesskey of &. However, if && is in the middle it works to create a real &
![]() |
||
Updated•16 years ago
|
Keywords: dev-doc-needed
Updated•16 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•