618788 - Not initialized used in CairoImageOGL::SetData

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Initialize mSize

Problem is that mSize not initialized in ctor.
and After ctor we usually call ::SetData
and that is comparing mSize with new Size... but mSize not initialized.

Also this cause sometime wrong logic executed... because mSize initialized from previous class (destroyed before)

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 497235 [details] [diff] [review]
Initialize mSize

Safe enough

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch is fine, but I don't think it's really the best fix for the bug. CairoImage::SetData should only be called once for any given CairoImage object, because Images are supposed to be immutable. So the mSize != aData.mSize check should simply be removed.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 497235 [details] [diff] [review]
Initialize mSize

No really, I think this is fine, but I think we should also remove the unnecessary code.

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Followup to last comment, Remove code,

Actually this is what I have done in the beginning...

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/722ffb1a0920

Comment 6

[Oleg Romashin (:romaxa)]

do we want single SetData per image still or should I close this bug?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should land your patch here.

Comment 8

[Oleg Romashin (:romaxa)]

Else condition was already removed...
A bit modified patch removing mSize check completely.
Pushed in my patch queue... 
http://hg.mozilla.org/users/romaxa_gmail.com/workbase_prc2/file/346821a07889/bug618788_remove_size_check.diff

Comment 9

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/92e1764dc180