619016 - Make SQLite installations able to upgrade

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement, P1)

Description

[Max Kanat-Alexander]

Right now, SQLite is missing all of its schema-altering code for upgrades. We need to implement bz_alter_colum, bz_add_column, bz_rename_column, all of the FK-adding/altering stuff, and anything else involved in an upgrade.

Comment 1

[Max Kanat-Alexander]

Attachment: Work In Progress

Here's a WIP, with an implementation of bz_alter_column.

Comment 2

[Max Kanat-Alexander]

Attachment: WIP 2

Here's an update ALTER implementation that supports $set_nulls_to and uses transactions (thanks to glob who found out that SQLite supports transactional DDL).

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, here we go! Technically I don't need review on this, since I'm the DB module owner, but I thought it might be nice to get some outside input in case there's anything that I could be doing better, etc. (Particularly since you already made some good suggestions to me in IRC yesterday.)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 497642 [details] [diff] [review]
v1

Okay, I'm going to check this patch in as-is, so that I can continue to do development and testing related to SQLite (including setting up some tinderboxen) but I'd still like a review, and I can update the patch after it's been checked in.

Comment 5

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/DB/Schema.pm
modified Bugzilla/DB/Schema/Sqlite.pm
Committed revision 7622.

Comment 6

[Max Kanat-Alexander]

Okay, there's a bug in the above patch when adding foreign keys to tables that don't have any foreign keys. I have a fix and will attach it here.

Comment 7

[Max Kanat-Alexander]

Attachment: Fix FK code, v1

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/DB/Schema/Sqlite.pm
Committed revision 7623.

Comment 9

[Max Kanat-Alexander]

And a bustage fix for _set_nulls_sql:

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/DB/Schema.pm
Committed revision 7625.

Comment 10

[Max Kanat-Alexander]

Comment on attachment 497642 [details] [diff] [review]
v1

This has been checked in for a while, so I'm assuming it's just not going to be a priority for glob to review, and it seems likely that review would just pass, given that things seem to have been working fine on trunk for a while.