Closed Bug 619350 Opened 14 years ago Closed 13 years ago

Better identify the 2 'Deadlock detector correctness' tests

Categories

(Core :: XPCOM, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla2.0b12
Tracking Status
status1.9.2 --- .17-fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

And explicitly distinguish test_deadlock_detector.cpp and TestDeadlockDetector.cpp which both identify themselves as 'Deadlock detector correctness' :-/
Blocks: 594263
Summary: Better distinguish the various "Potential deadlock detected" messages → Better distinguish the various "deadlock not detected" logs in the 2 'Deadlock detector correctness' tests
Depends on: 626091
No longer depends on: 626091
NB: If you know a simple syntax to add "__FILE__" to PASS() too, I would use it. Otherwise, it will just stay as is ftb.

***

This succeeded on
sgautherie.bz@free.fr – Sat Jan 15 17:40:57 2011 PST
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1295142171.1295144858.794.gz
Linux tryserver leak test build on 2011/01/15 17:42:51
Attachment #504200 - Flags: review?(jones.chris.g)
Attachment #504200 - Flags: review?(jones.chris.g) → review+
Comment on attachment 504200 [details] [diff] [review]
(Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests
[Checked in: Comment 2 & 4]

http://hg.mozilla.org/mozilla-central/rev/094a7967e171
Attachment #504200 - Attachment description: (Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit → (Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296727417.1296730634.16492.gz&fulltext=1
Linux mozilla-central leak test build on 2011/02/03 02:03:37

V.Fixed
Status: RESOLVED → VERIFIED
Comment on attachment 504200 [details] [diff] [review]
(Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests
[Checked in: Comment 2 & 4]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/54b82b081cc3
Attachment #504200 - Attachment description: (Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests [Checked in: Comment 2] → (Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests [Checked in: Comment 2 & 4]
Summary: Better distinguish the various "deadlock not detected" logs in the 2 'Deadlock detector correctness' tests → Better identify the 2 'Deadlock detector correctness' tests
The "3.6.15" we're releasing today does not fix this bug, the release containing this bug fix has been renamed to "3.6.16" and the bugzilla flags will be updated to reflect that soon. Today's release is a re-release of 3.6.14 plus a fix for a bug that prevented many Java applets from starting up.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: