626091 - 'make check': test_deadlock_detector test is compiled but not run

Status: RESOLVED INVALID

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295102824.1295104881.4989.gz&fulltext=1
Linux mozilla-central leak test build on 2011/01/15 06:47:04
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295102824.1295106340.11244.gz&fulltext=1
Linux x86-64 mozilla-central leak test build on 2011/01/15 06:47:04

I noticed this issue while Try-ing a patch for bug 619350:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1295105511.1295111936.790.gz&fulltext=1
Linux tryserver leak test build on 2011/01/15 07:31:51

(Maybe other Storage tests are affected too?)

***

http://mxr.mozilla.org/mozilla-central/source/storage/test/Makefile.in#63
{
64 ifdef MOZ_DEBUG
65 # FIXME bug 523392: test_deadlock_detector doesn't like Windows
66 # FIXME bug 523378: also fails on OS X
67 ifneq (,$(filter-out WINNT WINCE Darwin,$(OS_ARCH)))
68 CPP_UNIT_TESTS += \
69   test_deadlock_detector.cpp \
70   $(NULL)
71 endif
72 endif
}

Comment 1

[Serge Gautherie (:sgautherie)]

My bad: I got confused by very bug 619350 and the fact that 'make check' "stops" after the first test failure :-/