<audio controls> progress UI should be merged into controls (not enlarge the element)

RESOLVED INCOMPLETE

Status

()

Toolkit
Video/Audio Controls
RESOLVED INCOMPLETE
7 years ago
2 years ago

People

(Reporter: fryn, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 -)

Details

(URL)

(Reporter)

Description

7 years ago
While the source for an <audio controls> element is loading, the throbber enlarges the element and displays in the same region that it does for a <video> element.

This progress UI should be merged into the regular controls UI, so that it does not temporarily enlarge the element.

Comment 1

7 years ago
on Bug 548460 i attached a screenshot showing the problem
https://bug548460.bugzilla.mozilla.org/attachment.cgi?id=428844
and made that suggestion : "Maybe that the throbber could show up instead of
the duration while loading and then be replaced with duration, since duration
brings no information while loading (0:00)"

Comment 2

7 years ago
This destroys layout and should block.
blocking2.0: --- → ?
(Reporter)

Comment 3

7 years ago
(In reply to comment #2)
> This destroys layout and should block.

This bug is the more destructive subset of bug 538084, which has both been fixed and marked not blocking. Therefore, this is also not blocking.
blocking2.0: ? → ---

Comment 4

7 years ago
Bug 538084 was blocking 2.0 until yesterday. Then it was resolved as WFM, probably overlooking *this* issue.
blocking2.0: --- → ?
Keywords: regression

Updated

7 years ago
Duplicate of this bug: 548460
(Reporter)

Comment 6

7 years ago
(In reply to comment #4)
> Bug 538084 was blocking 2.0 until yesterday. Then it was resolved as WFM,
> probably overlooking *this* issue.

Why is this a regression?

Comment 7

7 years ago
See bug 538084 comment 4
Depends on: 620317
I've filed bug 620317 to handle unnecessary enlargement of the audio element's controls, which is I think what j.j. is referring to.
Assignee: fryn → nobody
blocking2.0: ? → -
(Reporter)

Updated

7 years ago
Status: ASSIGNED → NEW

Comment 9

7 years ago
as far as i'm concerned, this bug is about the throbber enlarging the native audio player and disturbing the pages layout.
Now that Firefox 4 is out (great work and thanks for it by the way), is it possible to have a look at ihis bug ?
I've made a suggestion above (comment 1)
thanks !
(In reply to comment #9)
> as far as i'm concerned, this bug is about the throbber enlarging the native
> audio player and disturbing the pages layout.

This should be fixed by bug 620317, which just needs dolske to review the patch... dolske can you review that patch please, so I can land it on mozilla-central before the migration over to firefox-experimental, and we lose the chance to fix this for Firefox 5? The cutoff is on April 12 IIRC.

Updated

6 years ago
Blocks: 672037
Blocks: 681553
(Reporter)

Comment 11

5 years ago
I'm pretty sure that we've fixed this.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
This wasn't fixed, it was just worked around by bug 698940. We still need a proper solution here.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Blocks: 1068523
(Reporter)

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago2 years ago
Keywords: regression
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.