619421 - <audio controls> progress UI should be merged into controls (not enlarge the element)

Status: RESOLVED INCOMPLETE

(Toolkit :: Video/Audio Controls, defect)

Description

[Frank Yan (:fryn)]

While the source for an <audio controls> element is loading, the throbber enlarges the element and displays in the same region that it does for a <video> element.

This progress UI should be merged into the regular controls UI, so that it does not temporarily enlarge the element.

Comment 1

[antistress]

on Bug 548460 i attached a screenshot showing the problem
https://bug548460.bugzilla.mozilla.org/attachment.cgi?id=428844
and made that suggestion : "Maybe that the throbber could show up instead of
the duration while loading and then be replaced with duration, since duration
brings no information while loading (0:00)"

Comment 2

[j.j.]

This destroys layout and should block.

Comment 3

[Frank Yan (:fryn)]

(In reply to comment #2)
> This destroys layout and should block.

This bug is the more destructive subset of bug 538084, which has both been fixed and marked not blocking. Therefore, this is also not blocking.

Comment 4

[j.j.]

Bug 538084 was blocking 2.0 until yesterday. Then it was resolved as WFM, probably overlooking *this* issue.

Comment 6

[Frank Yan (:fryn)]

(In reply to comment #4)
> Bug 538084 was blocking 2.0 until yesterday. Then it was resolved as WFM,
> probably overlooking *this* issue.

Why is this a regression?

Comment 7

[j.j.]

See bug 538084 comment 4

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

I've filed bug 620317 to handle unnecessary enlargement of the audio element's controls, which is I think what j.j. is referring to.

Comment 9

[antistress]

as far as i'm concerned, this bug is about the throbber enlarging the native audio player and disturbing the pages layout.
Now that Firefox 4 is out (great work and thanks for it by the way), is it possible to have a look at ihis bug ?
I've made a suggestion above (comment 1)
thanks !

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #9)
> as far as i'm concerned, this bug is about the throbber enlarging the native
> audio player and disturbing the pages layout.

This should be fixed by bug 620317, which just needs dolske to review the patch... dolske can you review that patch please, so I can land it on mozilla-central before the migration over to firefox-experimental, and we lose the chance to fix this for Firefox 5? The cutoff is on April 12 IIRC.

Comment 11

[Frank Yan (:fryn)]

I'm pretty sure that we've fixed this.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

This wasn't fixed, it was just worked around by bug 698940. We still need a proper solution here.