619422 - Split buttons in doorhanger notifications need styling in custom themes

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[:Margaret Leibovic]

Attachment: patch

Stephen says we should just use the existing custom XP styles for all non-aero themes. We can revert this change when bug 581193 is fixed, but for Firefox 4 we can just use the existing styles to prevent the buttons from looking broken.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Now that bug 581193 is fixed, can we revert the change by not doing it in the first place?

Comment 2

[Dave Townsend [:mossop]]

Sounds like it, re-nom if that isn't the case.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Bug 581193 was fixed by reverting the original "improve appearance" patch, which isn't really a proper solution. So I think we still need this to ensure that doorhangers look decent for custom-theme users...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(unless we don't care about those people having ugly doorhangers...)

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 497848 [details] [diff] [review]
patch

Since this appears to be an interim solution until bug 509642 is fixed, please don't remove the default-theme dependency, just comment it out and add a reference to bug 509642.

Comment 6

[:Margaret Leibovic]

Attachment: patch v2

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 503878 [details] [diff] [review]
patch v2

>-@media all and (-moz-windows-default-theme) {
>+/*XXX: apply styles to all themes until bug 509642 is fixed
>+@media all and (-moz-windows-default-theme) {*/
>   .popup-notification-menubutton[type="menu-button"] {
>     -moz-appearance: none;
>     border-radius: 3px;
>     padding: 0;

nit: put */ on its own line to make this more readable.

Comment 8

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/e69f42967b77

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Comment on attachment 503878 [details] [diff] [review]
> patch v2
> 
> >-@media all and (-moz-windows-default-theme) {
> >+/*XXX: apply styles to all themes until bug 509642 is fixed
> >+@media all and (-moz-windows-default-theme) {*/
> >   .popup-notification-menubutton[type="menu-button"] {
> >     -moz-appearance: none;
> >     border-radius: 3px;
> >     padding: 0;
> 
> nit: put */ on its own line to make this more readable.

http://hg.mozilla.org/mozilla-central/rev/a7026bd0bd6b