Split buttons in doorhanger notifications need styling in custom themes

VERIFIED FIXED in mozilla2.0b10

Status

()

defect
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
mozilla2.0b10
All
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [softblocker][doorhanger])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
Posted patch patch (obsolete) — Splinter Review
Stephen says we should just use the existing custom XP styles for all non-aero themes. We can revert this change when bug 581193 is fixed, but for Firefox 4 we can just use the existing styles to prevent the buttons from looking broken.
Attachment #497848 - Flags: review?(dao)
Assignee

Updated

9 years ago
blocking2.0: --- → ?
blocking2.0: ? → betaN+
Assignee

Updated

9 years ago
Whiteboard: [needs review dao]
Now that bug 581193 is fixed, can we revert the change by not doing it in the first place?
blocking2.0: betaN+ → ?
Sounds like it, re-nom if that isn't the case.
blocking2.0: ? → -
Bug 581193 was fixed by reverting the original "improve appearance" patch, which isn't really a proper solution. So I think we still need this to ensure that doorhangers look decent for custom-theme users...
(unless we don't care about those people having ugly doorhangers...)
blocking2.0: - → ?
blocking2.0: ? → final+
Whiteboard: [needs review dao] → [needs review dao][soft blocker]
Whiteboard: [needs review dao][soft blocker] → [needs review dao][softblocker]
Comment on attachment 497848 [details] [diff] [review]
patch

Since this appears to be an interim solution until bug 509642 is fixed, please don't remove the default-theme dependency, just comment it out and add a reference to bug 509642.
Attachment #497848 - Flags: review?(dao) → review-
Assignee

Comment 6

9 years ago
Posted patch patch v2Splinter Review
Attachment #497848 - Attachment is obsolete: true
Attachment #503878 - Flags: review?(dao)
Comment on attachment 503878 [details] [diff] [review]
patch v2

>-@media all and (-moz-windows-default-theme) {
>+/*XXX: apply styles to all themes until bug 509642 is fixed
>+@media all and (-moz-windows-default-theme) {*/
>   .popup-notification-menubutton[type="menu-button"] {
>     -moz-appearance: none;
>     border-radius: 3px;
>     padding: 0;

nit: put */ on its own line to make this more readable.
Attachment #503878 - Flags: review?(dao) → review+
Assignee

Comment 8

9 years ago
http://hg.mozilla.org/mozilla-central/rev/e69f42967b77
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs review dao][softblocker] → [softblocker]
Target Milestone: --- → mozilla2.0b10
(In reply to comment #7)
> Comment on attachment 503878 [details] [diff] [review]
> patch v2
> 
> >-@media all and (-moz-windows-default-theme) {
> >+/*XXX: apply styles to all themes until bug 509642 is fixed
> >+@media all and (-moz-windows-default-theme) {*/
> >   .popup-notification-menubutton[type="menu-button"] {
> >     -moz-appearance: none;
> >     border-radius: 3px;
> >     padding: 0;
> 
> nit: put */ on its own line to make this more readable.

http://hg.mozilla.org/mozilla-central/rev/a7026bd0bd6b
Whiteboard: [softblocker] → [softblocker][doorhanger]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.