Closed Bug 619964 Opened 9 years ago Closed 7 years ago

Implement FillPaint and StrokePaint filter sources

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: heycam, Assigned: longsonr)

References

()

Details

(Keywords: dev-doc-needed)

Attachments

(2 files, 2 obsolete files)

FillPaint and StrokePaint for in="" and in2="" attributes on filter primitives are not implemented and currently cause the whole filter to fail.
Attached patch WIP (obsolete) — Splinter Review
This is what I've got so far.

It passes http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-composite-03-f.html

but fails

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-overview-01-b.html

Something is wrong with the sizing of the filter input or output I think. See how the edges are too sharp.

I don't really need feedback on how the code is structured at this stage, and I know I've not put in any comments.
Attachment #637934 - Flags: feedback?(jwatt)
Oh and there's lots of duplicate code that needs factoring out too.
Attached patch WIP unbitrotted (obsolete) — Splinter Review
Attachment #637934 - Attachment is obsolete: true
Attachment #637934 - Flags: feedback?(jwatt)
Attachment #644968 - Flags: review?(jwatt)
(In reply to Robert Longson from comment #1)
> Something is wrong with the sizing of the filter input or output I think.
> See how the edges are too sharp.

If that's a bug (I think it is), then it's a preexisting bug with feGaussianBlur. The same thing happens with this testcase.
Compare it with Opera/Chrome.
Comment on attachment 644968 [details] [diff] [review]
WIP unbitrotted

That's my feedback for now until you've addressed the other things you mentioned.
Attachment #644968 - Flags: review?(jwatt)
(In reply to Jonathan Watt [:jwatt] from comment #4)
> it's a preexisting bug with feGaussianBlur.

I filed bug 776694 on that issue.
Attached patch patchSplinter Review
This passes http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-composite-03-f.svg but does not pass http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-overview-01-b.svg as fillpaint and strokepaint backgrounds have no blur. See comment 7 for more info.
Assignee: nobody → longsonr
Attachment #644968 - Attachment is obsolete: true
Attachment #648313 - Flags: review?(jwatt)
Attachment #648313 - Flags: review?(jwatt) → review+
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/22e600473209
Flags: in-testsuite+
Target Milestone: --- → mozilla17
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/22e600473209
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 786216
You need to log in before you can comment on or make changes to this bug.