Last Comment Bug 619964 - Implement FillPaint and StrokePaint filter sources
: Implement FillPaint and StrokePaint filter sources
Status: RESOLVED FIXED
: dev-doc-needed
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal with 1 vote (vote)
: mozilla17
Assigned To: Robert Longson
:
Mentors:
http://dev.w3.org/SVG/profiles/1.1F2/...
Depends on: 786216
Blocks: svg11tests
  Show dependency treegraph
 
Reported: 2010-12-17 11:27 PST by Cameron McCormack (:heycam)
Modified: 2012-08-28 05:16 PDT (History)
4 users (show)
longsonr: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (30.98 KB, patch)
2012-06-29 09:49 PDT, Robert Longson
no flags Details | Diff | Review
WIP unbitrotted (31.68 KB, patch)
2012-07-23 10:11 PDT, Jonathan Watt [:jwatt]
no flags Details | Diff | Review
testcase where feGaussianBlur fails to interpolate out of bounds "pixels" (269 bytes, image/svg+xml)
2012-07-23 12:02 PDT, Jonathan Watt [:jwatt]
no flags Details
patch (33.20 KB, patch)
2012-08-02 04:45 PDT, Robert Longson
jwatt: review+
Details | Diff | Review

Description Cameron McCormack (:heycam) 2010-12-17 11:27:58 PST
FillPaint and StrokePaint for in="" and in2="" attributes on filter primitives are not implemented and currently cause the whole filter to fail.
Comment 1 Robert Longson 2012-06-29 09:49:11 PDT
Created attachment 637934 [details] [diff] [review]
WIP

This is what I've got so far.

It passes http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-composite-03-f.html

but fails

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-overview-01-b.html

Something is wrong with the sizing of the filter input or output I think. See how the edges are too sharp.

I don't really need feedback on how the code is structured at this stage, and I know I've not put in any comments.
Comment 2 Robert Longson 2012-06-29 09:50:37 PDT
Oh and there's lots of duplicate code that needs factoring out too.
Comment 3 Jonathan Watt [:jwatt] 2012-07-23 10:11:58 PDT
Created attachment 644968 [details] [diff] [review]
WIP unbitrotted
Comment 4 Jonathan Watt [:jwatt] 2012-07-23 12:02:19 PDT
Created attachment 645016 [details]
testcase where feGaussianBlur fails to interpolate out of bounds "pixels"


(In reply to Robert Longson from comment #1)
> Something is wrong with the sizing of the filter input or output I think.
> See how the edges are too sharp.

If that's a bug (I think it is), then it's a preexisting bug with feGaussianBlur. The same thing happens with this testcase.
Comment 5 Jonathan Watt [:jwatt] 2012-07-23 12:03:12 PDT
Compare it with Opera/Chrome.
Comment 6 Jonathan Watt [:jwatt] 2012-07-23 12:53:16 PDT
Comment on attachment 644968 [details] [diff] [review]
WIP unbitrotted

That's my feedback for now until you've addressed the other things you mentioned.
Comment 7 Jonathan Watt [:jwatt] 2012-07-23 13:50:47 PDT
(In reply to Jonathan Watt [:jwatt] from comment #4)
> it's a preexisting bug with feGaussianBlur.

I filed bug 776694 on that issue.
Comment 8 Robert Longson 2012-08-02 04:45:50 PDT
Created attachment 648313 [details] [diff] [review]
patch

This passes http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-composite-03-f.svg but does not pass http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-overview-01-b.svg as fillpaint and strokepaint backgrounds have no blur. See comment 7 for more info.
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-08-05 17:40:08 PDT
https://hg.mozilla.org/mozilla-central/rev/22e600473209

Note You need to log in before you can comment on or make changes to this bug.