619964 - Implement FillPaint and StrokePaint filter sources

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

FillPaint and StrokePaint for in="" and in2="" attributes on filter primitives are not implemented and currently cause the whole filter to fail.

Comment 1

[Robert Longson [:longsonr]]

Attachment: WIP

This is what I've got so far.

It passes http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-composite-03-f.html

but fails

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-overview-01-b.html

Something is wrong with the sizing of the filter input or output I think. See how the edges are too sharp.

I don't really need feedback on how the code is structured at this stage, and I know I've not put in any comments.

Comment 2

[Robert Longson [:longsonr]]

Oh and there's lots of duplicate code that needs factoring out too.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: WIP unbitrotted

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: testcase where feGaussianBlur fails to interpolate out of bounds "pixels"

(In reply to Robert Longson from comment #1)
> Something is wrong with the sizing of the filter input or output I think.
> See how the edges are too sharp.

If that's a bug (I think it is), then it's a preexisting bug with feGaussianBlur. The same thing happens with this testcase.

Comment 5

[Jonathan Watt [:jwatt]]

Compare it with Opera/Chrome.

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 644968 [details] [diff] [review]
WIP unbitrotted

That's my feedback for now until you've addressed the other things you mentioned.

Comment 7

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] from comment #4)
> it's a preexisting bug with feGaussianBlur.

I filed bug 776694 on that issue.

Comment 8

[Robert Longson [:longsonr]]

Attachment: patch

This passes http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-composite-03-f.svg but does not pass http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-overview-01-b.svg as fillpaint and strokepaint backgrounds have no blur. See comment 7 for more info.

Comment 9

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/22e600473209

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/22e600473209