620053 - feedback button goes away when upgrading to latest beta 8

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[juan becerra [:juanb]]

When testing app updates going from Fx4b7 to b8 I saw a message saying Feedback 1.0.3 is not compatible with the version I was upgrading to. So the feedback button disappears.

We should block beta 8 on this.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Juan, on which platforms have you seen this problem? I tested the upgrade on the betatest channel and everything looks ok for me on OS X and Windows 7. The feedback button is present and the extension is compatible.

Comment 2

[juan becerra [:juanb]]

I think I tried Win7, Linux, and I just tried on XP. Here's a screencast where I start out with a clean profile on beta 7 and update to beta 8 after editing the channel prefs to point to beta test. In my original scenario I had first set up and used a Sync account on beta 7 for testing, but here it's a plain vanilla profile. http://screencast.com/t/hcmKYzdvV

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> set up and used a Sync account on beta 7 for testing, but here it's a plain
> vanilla profile. http://screencast.com/t/hcmKYzdvV

Can you please check the install.rdf of test pilot under the application's extension folder. In my upgraded version it is compatible with all 4.0 versions.

Comment 4

[LegNeato]

I bet the fact that the metadata on https://addons.mozilla.org/en-US/firefox/addon/13661/ stops at 4.0b8pre is the culprit.

My (uninformed) guess is that the versions and identifiers are the same and FF has already downloaded the updated metadata, which is incorrect (likely blowing away correct metadata?).

Comment 5

[Dave Townsend [:mossop]]

We marked testpilot as compatible with 4.0.* in Firefox 4b6 so I don't understand why this would be happening.

As well as looking at the install.rdf could you attach the extensions.sqlite from your profile before and after the upgrade.

Comment 6

[Dave Townsend [:mossop]]

(In reply to comment #4)
> I bet the fact that the metadata on
> https://addons.mozilla.org/en-US/firefox/addon/13661/ stops at 4.0b8pre is the
> culprit.
> 
> My (uninformed) guess is that the versions and identifiers are the same and FF
> has already downloaded the updated metadata, which is incorrect (likely blowing
> away correct metadata?).

Oh uh yes that is it. After the upgrade we sync compatibility info with that on AMO so it will effectively downgrade feedback's compatibility info to 4.0b8pre. Fixing that should resolve this. Not sure why Henrik wasn't seeing that though, network issues can stop it happening I guess.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> Fixing that should resolve this. Not sure why Henrik wasn't seeing that though,
> network issues can stop it happening I guess.

And I still don't have this problem. But which is more important here is, that I don't see a compatibility check during the restart of the browser. I'm always using a fresh profile for this update test. So I wonder what's going on here. Dave, I would tend to file a new bug for it.

Comment 8

[juan becerra [:juanb]]

Attachment: before update

Comment 9

[juan becerra [:juanb]]

Attachment: after update

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have filed bug 620349.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

This blocks release until resolved - do we know if it's a straight dupe of bug 620349 or a different issue? Who owns the resolution, here?

Comment 12

[Dave Townsend [:mossop]]

(In reply to comment #11)
> This blocks release until resolved - do we know if it's a straight dupe of bug
> 620349 or a different issue? Who owns the resolution, here?

Not a dupe at all. Jono owns this bug, he is the one with access to AMO to update the compatibility info there.

Comment 13

[Jono Xia]

AMO compatibility info has been updated.  Could one of you please verify that this fixes the bug?

Comment 14

[juan becerra [:juanb]]

I've tested now on XP going from b7 to b8 and it's working now. The extension compatibility check dialog is shown briefly, with no problems, and the resulting build has the Feedback button. I will check a couple more platforms before calling it verified.

Comment 15

[juan becerra [:juanb]]

I have tested XP, Win7, Win2000, Linux, Mac on en-US and a couple of locales and going from b7 or earlier to b8. The feedback button is preserved after update. You can mark it as fixed.