Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Toolbar corner not rounded when using in-content UI like add-on manager

VERIFIED FIXED in Firefox 8

Status

()

Firefox
Theme
--
trivial
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: redsign, Assigned: Unfocused)

Tracking

({ux-consistency})

Trunk
Firefox 8
All
Windows 7
ux-consistency
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101218 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101218 Firefox/4.0b9pre

The corners of the toolbar are rounded since the landing of Bug 589259 - top outside corners of navigation toolbar need border radius. The corners become rectangular again when viewing in-content UI like the new add-on manager. 

Reproducible: Always

Steps to Reproduce:
1.Open the add-on manager

Actual Results:  
The top outside corners of the browser chrome become rectangular.

Expected Results:  
The corners should be rounded as before.
(Reporter)

Comment 1

7 years ago
Created attachment 498529 [details]
Comparison of the outside corners with and without in-content UI

Outside corner with a tab showing a regular website on the left and with showing the add-on manager on the right.
(Reporter)

Updated

7 years ago
Depends on: 571970, 589259

Comment 2

7 years ago
Confirmed with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101217 Firefox/4.0b9pre ID:20101217030324
Blocks: 571970, 589259
Status: UNCONFIRMED → NEW
No longer depends on: 571970, 589259
Ever confirmed: true
Keywords: ux-consistency
Version: unspecified → Trunk
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
OS: All → Windows 7
Created attachment 541274 [details] [diff] [review]
Patch v1

Also works pretty well with the patch with bug 644721 (aside from the bitrot).
Attachment #541274 - Flags: review?(dao)

Updated

6 years ago
Attachment #541274 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/9c3ea24a7bff
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/9c3ea24a7bff
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Vlad, could you please verify this bug on Win7? Currently I do not have access to such a machine. Thanks.

Comment 7

6 years ago
Are you sure it looks good?

http://s4.postimage.org/60970dyka/Untitled.png

http://s4.postimage.org/fzt0vrmzz/Untitled.png
Bogas, does it look the same with a Nightly build for you? Not sure if there have been landed any other patches on the UX branch which could affect this.
Note that the UX branch contains unfinished patches - such as the patch from bug 644721, which will need updating to take into account the fix for this bug. Part of the bitrot I mentioned in comment 3 is taking into account the CSS changes made in this bug.
Mozilla/5.0 (Windows NT 6.1; rv:8.0a2) Gecko/20110825 Firefox/8.0a2

It has been fixed on latest Aurora and Nightly.
Setting resolution to Verified Fixed.
Thanks.
Status: RESOLVED → VERIFIED

Updated

6 years ago
Duplicate of this bug: 617914
You need to log in before you can comment on or make changes to this bug.