620177 - Sniff for mobile devices on submission page load

Status: VERIFIED FIXED

(Input :: General, enhancement, P1)

Description

[Aakash Desai [:aakashd]]

Steps to reproduce:
1. Go to input.mozilla.com/happy or /sad from fennec.
2. Go to input.stage.mozilla.com/happy or /sad from fennec.

Actual Results:
Desktop submission page is loaded.

Expected Results:
Mobile submission pages should be loaded.

Comment 1

[Fred Wenzel [:wenzel]]

Are they supposed to do that? That's a new feature, which we aren't supposed to add during code freeze.

It's pretty simple though, so I'll probably take a look on Monday.

Comment 2

[Fred Wenzel [:wenzel]]

I'll need to mess with the way we detect Firefox mobile a bit for this, and I'd rather have it thoroughly tested before we go live, so I can't do it during this code freeze. Punting to 3.0.

Comment 3

[Aakash Desai [:aakashd]]

This is actually a regression as clicking on either of the happy/sad buttons in the client will show up the desktop submission pages instead.

Comment 4

[Fred Wenzel [:wenzel]]

We discussed this in person shortly, and while it is a moot point if this is a regression or not, I am wondering where the bug came from. It seems to me that the extension is not pointing to m.input.moz.com anymore, but just to input.moz.com now. Do we need to inform the Mobile team of this?

Comment 5

[Aakash Desai [:aakashd]]

Aye; I think that's the best option going forward. Unfortunately, they're about to release, so its pretty much impossible to change it for beta 3.

Comment 6

[Fred Wenzel [:wenzel]]

I am forwarding known mobile devices to the same path on the mobile domain now. The URLs covered for now (subject to change in bug 621088) are the dashboard as well as the feedback pages.

http://github.com/fwenzel/reporter/commit/3835b47

This contains unit tests.

Comment 7

[Rebecca Billings [:rbillings]]

Verified fennec redirected to m.input.stage, and displayed the correct happy/sad mobile page