62050 - tooltips not displayed for title attributes

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[HJ]

As I just discovered the Title text is no longer displayed. This must be an
regression. As it worked before! And it still does in Netscape 6/6.0.

Link, images you name it, they no longer display the title informatie. So for
now, we no longer have ALT and Title information in SM, this is to odd for
words! I feel sorry for that.

Friendly, HJ

Comment 1

[HJ]

Oeps, forgot something, tested with build 2000120504 on WinNT4 Sp6
I'm only human.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I see this on 2000-12-05-08 on linux.  OS->All.  I would confirm but I am not
sure what the component should be for this.  Other tooltips seem to work
fine.... This is definitely a regression from this past weekend -- the 11-30-08
build worked just fine.

Comment 3

[Barry Marshall]

...and also Win2K 1205 and OS/2 "1201" (1130).

I'll attach some pictures as well.

Comment 4

[Barry Marshall]

Attachment: Current 1205 partial screen capture. Note lack of tooltip.

Comment 5

[Barry Marshall]

Attachment: ... and the same thing under NS 4.75 (but it works).

Comment 6

[James Green]

Confirming on Linux build 2000120508, OS->All. Changing summary to remove the
"alt" attribute since the spec says that alt is for inline use. Moving Component
to XPApps on advice from Asa.

This regressed I *think* over the weekend, can't be precise. Only regressed in
web browser on html pages, not in general product.

Comment 7

[Asa Dotzler [:asa]]

this regressed between the 120208 and 120306 builds.

Comment 8

[Asa Dotzler [:asa]]

reassign to default component owner.  I've narrowed this down further.  This
regressed after the 1120206 and before the 122021 build

Comment 9

[Asa Dotzler [:asa]]

looks like jag, blake and dbaron were the ones checking in in that time frame.
Can you all take a look at your checkins and see if maybe one of them regressed
this.  Thanks

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'd say jag is most likely, since he cleaned up large parts of navigator.js,
although there's a small chance it could have been my navigator.js or
nsGlobalWindow changes.

jag, could you have a look?  Assigning to jag... :-)

Comment 11

[Peter "jag" Annema]

Hrm... My mistake...

Fix is easy:
-      if (tipElement.nodeType == Node.ELEMENT_NODE) {
+     if (tipElement.nodeType == 1) {

I'll attach a real patch when I'm in Linux.

Comment 12

[Peter "jag" Annema]

Attachment: [patch] Fix my bad

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail], per discussions on IRC. (const Node = { .. })

Comment 14

[Blake Ross]

r=blake on the patch discussed on IRC, and 20 whippings for jag.

Comment 15

[HJ]

Hm, it seems this is going to work out right. Thanks guy.

And please jump into line 91, getting this error day by day!

Comment 16

[Peter "jag" Annema]

This should be fixed now.

HJ, can you file a new bug on that "error on line 91"?

Comment 17

[HJ]

Peter, please take a look at 61029 first will you?

Friendly, HJ

Comment 18

[Fabian Guisset]

*** Bug 62262 has been marked as a duplicate of this bug. ***

Comment 19

[Matthew T (active 1999-2002)]

*** Bug 62252 has been marked as a duplicate of this bug. ***

Comment 20

[Loco]

Assigning dependency, changing Plat/OS to ALL, VERIFIED on Mac OS 2001-01-04-08.