Currently selected tab should be indicated in Panorama

VERIFIED FIXED in Firefox 4.0

Status

defect
P4
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: alice0775, Assigned: shorlander)

Tracking

Trunk
Firefox 4.0
x86
Linux
Dependency tree / graph
Bug Flags:
in-litmus +

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [visual][ux])

Attachments

(3 attachments)

Reporter

Description

9 years ago
Build Identifier:
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre ID:20101221030401

Currently selected tab should be indicated in Panorama.


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Open several tabs
3. Enter Panorama

Actual Results:
 There is no focus-ring/border-highlight for currently selected tab.

Expected Results:
 Currently selected tab should be indicated.

Updated

9 years ago
Blocks: 598154
Priority: -- → P4

Comment 1

9 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 2

9 years ago
bugspam (removing b9)
No longer blocks: 598154

Comment 3

9 years ago
Assigning to Faaborg for design.
Assignee: nobody → faaborg
Alice, do you still see this bug on recent builds?
Keywords: qawanted
Whiteboard: [WFM?][visual][ux]
Blocks: 627096
No longer blocks: 608028
Reporter

Comment 5

9 years ago
Posted image screenshot
Yes, There is still this problem with new profile.
The appearance of all thumbnails looks same.
Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110120 Firefox/4.0b10pre ID:20110120030332
Requesting softblocker status. Apparently the linux theme never had this highlighting? Crazy and unfortunate.
blocking2.0: --- → ?
Flags: in-litmus?
Whiteboard: [WFM?][visual][ux] → [visual][ux]
Patch adds a highlight using the system theme color to the currently focused tab in Panorama
Attachment #506651 - Flags: review?(ian)
Attachment #506653 - Attachment description: Screenshot → Screenshot of patch

Comment 9

9 years ago
This sounds like a new feature, does it need a beta? Should it be blocking?
(In reply to comment #9)
> This sounds like a new feature, does it need a beta? Should it be blocking?

This behavior is present in Panorama on Windows and OSX so I don't think this would qualify as a new feature. I do not think it needs a beta.

Cross platform consistency and semi-broken functionality seems like it would qualify as a softblocker.
Comment on attachment 506651 [details] [diff] [review]
Linux tab focus highlight - 01

Excellent
Attachment #506651 - Flags: review?(ian) → review+
Comment on attachment 506651 [details] [diff] [review]
Linux tab focus highlight - 01

Looks great!
Attachment #506651 - Flags: feedback+
Attachment #506651 - Flags: approval2.0? → approval2.0+
blocking2.0: ? → -
Pushed http://hg.mozilla.org/mozilla-central/rev/85ec8d10fdfb
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
added some clearer expectations to existing test case.
Flags: in-litmus? → in-litmus+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.