62078 - [RFE] Ctrl-F5 should do a forced reload (like shift-ctrl-R)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[David Hallowell]

Carried over from bug #61330

Ctrl-F5 should also do a forced reload of the page from the server. I've changed
this from shift-F5 to ctrl-F5 because the F5 shortcut is provided for
ocmpatibility with IE shortcuts and according to the IE help file Ctrl-F5 is the
correct shortcut to force an reload from the server in IE (version 5 at least -
I assume the same with all versions).

Note: ctrl-R also works in IE for reloading but for some reason they just had to
list F5 as the default shortcut.

Comment 1

[Blake Ross]

I think being consistent with ourself is more important than being consistent 
with a competitor product, and that means shift+F5.  We could support ctrl+F5 
also, but I think the number of shortcuts we have for all of these actions is 
ridiculous.

Comment 2

[David Hallowell]

Isn't the whole point of F5 support to be consistent for IE users?
Shift-F5 does nothing on IE, and ctrl-R is the proper reload shortcut for
Mozilla and previous Netscape browsers, so F5 should have the IE behaviour
otherwise it's no point supporting it.

The F5 shortcut is defined in the platformNavigationBindings.xul file and the
comment states it's just to support IE compatibility:
    <!-- Supporting IE 'refresh' shortcut key -->
    <key id="reloadIE" keycode="VK_F5" observes="canReload"/>

So shift-F5 means nothing to Netscape users and nothing to IE users so why
support it?

I don't have Netscape 4.x on this machine but I've just asked someone and they
claim F5 does nothing on Netscape anyways so shift-F5 is not supported on *any*
mainstream browser AFAIK.

Comment 3

[Peter "jag" Annema]

I agree with David here. F5 is purely IE compatibility, so if IE does ctrl-F5
that's what we should do.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Yes, compatibility with IE is the reason I hooked up F5 in the first place. 

Hardcore Netscape 4.x users can use Shift+Ctrl+R or Shift+Reload. 

Comment 5

[Blake Ross]

Now we run into the same thing I just told jag recently: it is bad coding 
practice to have one function called generically, and then do one of two things 
depending on whether a modifier is down.  I said there should be two distinct, 
clear functions to reload and forced reload, and the appropriate one should be 
called when the appropriate modifier is down (e.g. determining which function 
to call is done immediately, in the xul, where it belongs).  jag, you didn't 
seem to agree with this iirc.  So...?

Comment 6

[Peter "jag" Annema]

I think I said it could be addressed when necessary. Now is the time :-)

Split BrowserReallyReload up into:

function reload()
{
  var reloadFlags = nsIWebNavigation.LOAD_FLAGS_NONE;

  getWebNavigation().reload(reloadFlags);
}

function reallyReload()
{ 
  var reloadFlags = nsIWebNavigation.LOAD_FLAGS_BYPASS_PROXY |
nsIWebNavigation.LOAD_FLAGS_BYPASS_CACHE;

  getWebNavigation().reload(reloadFlags);
}

and call the right functions from the right places (|if (event.shiftKey)
reallyReload() else reload();|)

Comment 7

[Blake Ross]

Attachment: [patch] ignore the link stuff, that's another bug

Comment 8

[Peter "jag" Annema]

r=jag minus link stuff ;-)

Comment 9

[Blake Ross]

cc'ing alec, guessing he can figure out why

Comment 10

[Alec Flett]

looks good but why is _content.focus() removed?

Comment 11

[Peter "jag" Annema]

It was moved to its proper spot :-)

Comment 12

[Blake Ross]

Right, what jag said; we shouldn't be focusing the _content just when 
retrieving the uri or shortcut (and can't, since windows like open web location 
are using that method also).

So....sr?

Comment 13

[Blake Ross]

Fix checked in.

Comment 14

[sairuh (rarely reading bugmail)]

vrfy fixed [F5 works] on winNT using 2001.06.07.06-branch comm bits.