621066 - [regression] Panning about: pages always makes sidebar disappear

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Martijn Wargers (dead)]

When you pan around in pages like about:firefox and you have one of the sidebars open (for example the tab sidebar), the sidebar and url bar suddenly disappear after you've panned after a certain threshold.
I see this happening on Android and Maemo.

I see this only happening on about: pages. On regular pages, this works as expected.

Maybe this is related to bug 597081?

Comment 1

[Martijn Wargers (dead)]

Also happens when reloading the about:* page.

Comment 2

[Martijn Wargers (dead)]

Steps to reproduce:
- Go to about:firefox
- Pan to the right to open the left sidebar
- Pan upwards to scroll down

Expected result:
- The left sidebar should stay open

Actual result:
- The left sidebar is suddenly closed, after scrolling down for a while.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I know what you mean because I've seen this bug a few times, but for some reason I can't reproduce it today.

Comment 4

[Martijn Wargers (dead)]

I can still see it happening on 2011-01-03 builds on Android and Maemo.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is a regression from bug 598391. With this patch the testcase still works for me and I don't the wrong sidebars/urlbar behavior you were referring to.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 511771 [details] [diff] [review]
Patch

>+          if (position.x)
>+            this.hideSidebars();
>+
>+          if (position.y != 0)
>+            this.hideTitlebar();

Nit: Please change the "if" tests to match (add "!= 0" to both, or remove it from both).

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c4d737c1137e

Comment 8

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110526 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)