[regression] Panning about: pages always makes sidebar disappear

VERIFIED FIXED

Status

Fennec Graveyard
Panning/Zooming
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: vingtetun)

Tracking

({regression})

Trunk
regression

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
When you pan around in pages like about:firefox and you have one of the sidebars open (for example the tab sidebar), the sidebar and url bar suddenly disappear after you've panned after a certain threshold.
I see this happening on Android and Maemo.

I see this only happening on about: pages. On regular pages, this works as expected.

Maybe this is related to bug 597081?
(Reporter)

Comment 1

7 years ago
Also happens when reloading the about:* page.
(Reporter)

Updated

7 years ago
OS: Windows 7 → All
Hardware: x86 → ARM
(Reporter)

Comment 2

7 years ago
Steps to reproduce:
- Go to about:firefox
- Pan to the right to open the left sidebar
- Pan upwards to scroll down

Expected result:
- The left sidebar should stay open

Actual result:
- The left sidebar is suddenly closed, after scrolling down for a while.
I know what you mean because I've seen this bug a few times, but for some reason I can't reproduce it today.
(Reporter)

Comment 4

7 years ago
I can still see it happening on 2011-01-03 builds on Android and Maemo.
Created attachment 511771 [details] [diff] [review]
Patch

This is a regression from bug 598391. With this patch the testcase still works for me and I don't the wrong sidebars/urlbar behavior you were referring to.
Assignee: nobody → 21
Attachment #511771 - Flags: review?(mbrubeck)
Blocks: 598391
tracking-fennec: --- → ?
Component: General → Panning/Zooming
Keywords: regression
QA Contact: general → pan-zoom
Hardware: ARM → All
Summary: Panning about: pages always makes sidebar disappear → [regression] Panning about: pages always makes sidebar disappear
Comment on attachment 511771 [details] [diff] [review]
Patch

>+          if (position.x)
>+            this.hideSidebars();
>+
>+          if (position.y != 0)
>+            this.hideTitlebar();

Nit: Please change the "if" tests to match (add "!= 0" to both, or remove it from both).
Attachment #511771 - Flags: review?(mbrubeck) → review+
http://hg.mozilla.org/mobile-browser/rev/c4d737c1137e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 8

6 years ago
VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110526 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
tracking-fennec: ? → 7+
status-firefox7: --- → fixed
You need to log in before you can comment on or make changes to this bug.